Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Improve home page UI. #144

Merged
merged 25 commits into from
Apr 1, 2021
Merged

Conversation

xaerru
Copy link
Contributor

@xaerru xaerru commented Mar 27, 2021

Made the UI of the home page a little better.

@xaerru
Copy link
Contributor Author

xaerru commented Mar 28, 2021

Site isn't responsive on Netlify, but when I run it locally it is.

@xaerru
Copy link
Contributor Author

xaerru commented Mar 28, 2021

I don't know why this is happening but whenever I open it in mobile view it doesn't render correctly until I click on a card and then go back to the home page.

@xaerru
Copy link
Contributor Author

xaerru commented Mar 28, 2021

It's changing after building. So it's not a Netlify problem

@xaerru
Copy link
Contributor Author

xaerru commented Mar 28, 2021

I overthought it. It was really simple. I didn't even need react-device-detect.

@ming-tsai
Copy link
Member

Hi @gauravsingh5,
Thanks for contributions, could your replace double quotes to single?
I should configure prettier

@ming-tsai
Copy link
Member

ming-tsai commented Apr 1, 2021

Hi @gauravsingh5,
Please ensure the card is the same size and the ArrowForward button should on the left side
image
And keep 3 cards on one flow
image

@ming-tsai ming-tsai self-requested a review April 1, 2021 14:29
@ming-tsai ming-tsai added the enhancement New feature or request label Apr 1, 2021
Copy link
Member

@ming-tsai ming-tsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, and rollback the change of hiding navbar, when has a lot of dungeons, or in the future, we will use it

src/pages/404.jsx Outdated Show resolved Hide resolved
src/utils/styles.js Outdated Show resolved Hide resolved
src/pages/index.jsx Outdated Show resolved Hide resolved
@xaerru
Copy link
Contributor Author

xaerru commented Apr 1, 2021

Do you know how to size it?

@xaerru
Copy link
Contributor Author

xaerru commented Apr 1, 2021

image
I just sliced the excerpt

@xaerru
Copy link
Contributor Author

xaerru commented Apr 1, 2021

Maybe we can add 3 dots at the end.

@ming-tsai
Copy link
Member

For me is good

<Typography gutterBottom variant='h5' component='h2'>
{info.display}
</Typography>
<Typography>{post.excerpt.slice(0, 65)}</Typography>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why just 65 characters?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you just want 65 characters, you could use the gatsby graphql query, on the pruneLength change to 65
image

@xaerru
Copy link
Contributor Author

xaerru commented Apr 1, 2021

It seemed to work

@xaerru
Copy link
Contributor Author

xaerru commented Apr 1, 2021

This is a temporary fix btw, we need to find a permanent one

@ming-tsai
Copy link
Member

It fails because you change the text alignment to the center?

@xaerru
Copy link
Contributor Author

xaerru commented Apr 1, 2021

It's the number of lines it takes

@xaerru
Copy link
Contributor Author

xaerru commented Apr 1, 2021

image
This is right align

@xaerru
Copy link
Contributor Author

xaerru commented Apr 1, 2021

It's without the slice btw.

@ming-tsai
Copy link
Member

image
This is right align

You could specify the pruneLength to another length
image

@ming-tsai
Copy link
Member

But the question, why the current is align?
image

@xaerru
Copy link
Contributor Author

xaerru commented Apr 1, 2021

image
Prune 30 in English vs Chinese

@xaerru
Copy link
Contributor Author

xaerru commented Apr 1, 2021

image
This is Prune 10

@xaerru
Copy link
Contributor Author

xaerru commented Apr 1, 2021

I guess prune 10 should work.

@ming-tsai
Copy link
Member

I will check your branch

@xaerru
Copy link
Contributor Author

xaerru commented Apr 1, 2021

Just check the deploy preview

@ming-tsai
Copy link
Member

The 10 prune didn't show the description of dungeon

@xaerru
Copy link
Contributor Author

xaerru commented Apr 1, 2021

We can leave it like a teaser, if they click on it they see the full description.

@ming-tsai
Copy link
Member

ming-tsai commented Apr 1, 2021

Let me check what is going on with the card

@ming-tsai
Copy link
Member

Hi @gauravsingh5,
Could you set the prune length to 100? I will check when merge to master

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@ming-tsai ming-tsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🎉🙌🙌🙌

@ming-tsai ming-tsai merged commit 3ec65c2 into MakeContributions:master Apr 1, 2021
@ming-tsai ming-tsai linked an issue Apr 2, 2021 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beautify the page
2 participants