docs(release): tag step must be signed+annotated (git tag -s -m) - #624
Merged
Conversation
The "Cutting one" tag step showed `git tag v0.2.0`, but the repo config forces SSH-signed tags (tag.gpgSign=true, gpg.format=ssh) and every prior release tag is signed — so a bare `git tag <name>` fails `fatal: no tag message?`. Document the working form `git tag -s -m "maxplayer vX.Y.Z" vX.Y.Z <commit>` and the message convention. Caught while cutting v0.2.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the RELEASE.md tag step to the signed + annotated form the repo config requires.
Why
The "Cutting one" step showed
git tag v0.2.0, buttag.gpgSign=true+gpg.format=ssh(and every prior release tag is SSH-signed) means a baregit tag <name>failsfatal: no tag message?. The next cutter would hit it. Caught while cutting v0.2.0 (which shipped fine using the corrected form).Change (RELEASE.md only)
git tag -s -m "maxplayer vX.Y.Z" vX.Y.Z <commit>, plus a note on the forced-signing config and themaxplayer vX.Y.Zmessage convention.Scope note
Doc half of the post-v0.2.0 release-ops polish. The other item — bumping the node20-targeting actions (
checkout/upload-artifact/download-artifact/setup-nodeare@v4; latest majors are v7/v7/v8/v7) — is split into its own deliberate, dry-run-gated PR: it's a 3–4 major jump across the build→publish artifact path and needs breaking-change review, not a doc-PR ride-along.🤖 Generated with Claude Code