add unsafe_set!(::Textbox, ::String)

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## [Unreleased]
 
+- Add `unsafe_set!(::Textbox, ::String)` [#4417](https://github.com/MakieOrg/Makie.jl/pull/4417)
 - Disabled unit prefix conversions for compound units (e.g. `u"m/s"`) to avoid generating incorrect units. [#4583](https://github.com/MakieOrg/Makie.jl/pull/4583)
 - Add kwarg to rotate Toggle [#4445](https://github.com/MakieOrg/Makie.jl/pull/4445)
 - Fix orientation of environment light textures in RPRMakie [#4629](https://github.com/MakieOrg/Makie.jl/pull/4629).

src/makielayout/blocks/textbox.jl

@@ -86,8 +86,7 @@
 
         if ci > length(bbs)
             # correct cursorindex if it's outside of the displayed charbbs range
-            cursorindex[] = length(bbs)
-            return
+            ci = cursorindex[] = length(bbs)
         end
 
         if 0 < ci < length(bbs)
@@ -344,10 +343,18 @@
 Sets the stored_string of the given `Textbox` to `string`, triggering listeners of `tb.stored_string`.
 """
 function set!(tb::Textbox, string::String)
-    if !validate_textbox(string, tb.validator[])
+    if validate_textbox(string, tb.validator[])
+        unsafe_set!(tb, string)
+    else
         error("Invalid string \"$(string)\" for textbox.")
     end
+end
 
+"""
+    unsafe_set!(tb::Textbox, string::String)
+Sets the stored_string of the given `Textbox` to `string`, ignoring the possibility that it might not pass the validator function.
+"""
+function unsafe_set!(tb::Textbox, string::String)
     tb.displayed_string = string
     tb.stored_string = string
     nothing

test/makielayout.jl

@@ -554,3 +554,10 @@ end
     Toggle(f[2,1], orientation=:vertical)
     Toggle(f[3,1], orientation=pi/4)
 end
+
+@testset "Textbox set! & unsafe_set!" begin
+    f = Figure()
+    tb = Textbox(f[1,1], validator = isequal("hi"))
+    @test isnothing(Makie.set!(tb, "hi"))
+    @test_throws ErrorException Makie.set!(tb, "there")
+    @test isnothing(Makie.unsafe_set!(tb, "there"))