Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Makie test files #4711

Merged
merged 11 commits into from
Feb 7, 2025
Merged

Reorganize Makie test files #4711

merged 11 commits into from
Feb 7, 2025

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Jan 9, 2025

Description

I've been thinking for a while that organizing tests into a few folders would be helpful so I did that here.

As of 8e09652:

  • This does not change any test that was included before
  • This does split up events.jl without any functional changes (1)
  • This does change and include tests that were previously not running (zoom_pan.jl, timings.jl). (1) zoom_pan has been merged with the Axis tests from events.jl.
  • This does change 3 lines of Makie code - 2 to catch BudgetedTimer callbacks erroring and 1 fixing stop!(timer) being unavailable in WGLMakie (how did this not error before? Does isopen(screen) not become false after closing a WGLMakie screen?)

Type of change

  • Test/CI improvements

@ffreyer ffreyer added the skip-changelog Skips changelog enforcer label Jan 9, 2025
@MakieBot
Copy link
Collaborator

MakieBot commented Jan 10, 2025

Benchmark Results

SHA: 6dbb2773fb931e8b0e4d599a773e902f000e0cfe

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

GLMakie
CairoMakie
WGLMakie

@ffreyer ffreyer marked this pull request as ready for review January 11, 2025 11:38
@ffreyer
Copy link
Collaborator Author

ffreyer commented Feb 7, 2025

Double checked the number of tests after the last merge, seems correct (54 more than master)

@ffreyer ffreyer merged commit b7cc362 into master Feb 7, 2025
22 checks passed
@ffreyer ffreyer deleted the ff/test-organization branch February 7, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog enforcer
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants