Skip to content

Fix WGLMakie nan error#4772

Merged
ffreyer merged 4 commits intomasterfrom
ff/fix-wglmakie-nan-error
Feb 14, 2025
Merged

Fix WGLMakie nan error#4772
ffreyer merged 4 commits intomasterfrom
ff/fix-wglmakie-nan-error

Conversation

@ffreyer
Copy link
Copy Markdown
Collaborator

@ffreyer ffreyer commented Feb 10, 2025

Description

Probably supersedes #4727

While merging #4742 I ran into an issue where Axis3 would stop working when rotated in vscode. In the Browser this produces the same chain of errors as #4727. The "stack trace" of this issue is:

  • Plane produces a NaN vector from normalize(Vec3f(0))
  • while handling an edge case in to_clip_space
  • which is called in lines
  • which come from the Axis3 background poly plots

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Copy Markdown
Collaborator

MakieBot commented Feb 10, 2025

Benchmark Results

SHA: f61edc7796cf50cef1464cb846a04cc1fc6fcc32

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

GLMakie
CairoMakie
WGLMakie

Comment thread src/utilities/Plane.jl
@ffreyer ffreyer merged commit c7eb320 into master Feb 14, 2025
@ffreyer ffreyer deleted the ff/fix-wglmakie-nan-error branch February 14, 2025 12:58
@ffreyer ffreyer mentioned this pull request Feb 19, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

3 participants