Add a MacOS test runner to GLMakie #4788
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we might need to implement the suggestions in https://developer.apple.com/library/archive/technotes/tn2229/_index.html#//apple_ref/doc/uid/DTS40008924-CH1-SECTION2 to get Mac working on CI. |
Benchmark ResultsSHA: 45192fa2c7a32ddd6fcd103d891dce015d76d9dc Warning These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are a lot of issues on Mac that we don't catch, this PR is a step in the direction of catching those.
We may also want to set the JULIA_NUM_THREADS optionally in some runs to test if we have multithreading issues.
This is a CI change only.