Conversation
bmh7190
commented
Feb 7, 2025
|
|
||
| class NotificationListView(APIView): | ||
| # permission_classes = [IsAuthenticated] # 로그인한 사용자만 접근 가능 | ||
|
|
Contributor
Author
There was a problem hiding this comment.
여기에 나중에 알림 삭제 기능 같은거 넣으면 될 듯!
|
|
||
| # 알림 | ||
| path("notifications", NotificationListView.as_view(), name="notification-list"), | ||
|
|
Contributor
Author
There was a problem hiding this comment.
지금은 급한대로 알림을 account 앱에 넣었지만,, 나중에 앱을 분리하는게 좋을 듯 합니다!
Contributor
There was a problem hiding this comment.
좋습니다 나중에 notice 앱 따로 만들면 될거같아요!
Contributor
|
전체적인 코드에 이상없어보입니다!! 포스트맨에서 돌아갔으면 바로 머지해도될거같아요! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🚀
Work Description 💚
PR 참고 사항