Update Node.js from v16 to v20 (#84) (#85)

* Update Node.js from v16 to v20 (#84) https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ Closes #84
Malinskiy · May 29, 2024 · 9f46de8 · 9f46de8
1 parent 39a788b
commit 9f46de8
Show file tree

Hide file tree

Showing 8 changed files with 64 additions and 27 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -11,10 +11,10 @@ jobs:
         distribution: 'temurin'
         java-version: '17'
     - name: test install-sdk
-      run: npm config delete prefix && source ~/.nvm/nvm.sh && nvm install v16.15.0 && npm install && npm ci && npm run build
+      run: npm config delete prefix && source ~/.nvm/nvm.sh && nvm install v20.14.0 && npm install && npm ci && npm run build
       working-directory: install-sdk
     - name: test emulator-run-cmd
-      run: npm config delete prefix && source ~/.nvm/nvm.sh && nvm install v16.15.0 && npm install && npm ci && npm run build
+      run: npm config delete prefix && source ~/.nvm/nvm.sh && nvm install v20.14.0 && npm install && npm ci && npm run build
       working-directory: emulator-run-cmd
     - uses: ./install-sdk
       name: install sdk
@@ -31,6 +31,7 @@ jobs:
         tag: default
         abi: x86
         cmd: adb shell getprop
+        cmdOptions: -noaudio -no-boot-anim -no-window
         bootTimeout: 500
     - uses: actions/upload-artifact@v1
       with:
@@ -46,10 +47,10 @@ jobs:
           distribution: 'temurin'
           java-version: '17'
       - name: test install-sdk
-        run: npm config delete prefix && source ~/.nvm/nvm.sh && nvm install v16.15.0 && npm install && npm ci && npm run build
+        run: npm config delete prefix && source ~/.nvm/nvm.sh && nvm install v20.14.0 && npm install && npm ci && npm run build
         working-directory: install-sdk
       - name: test emulator-run-cmd
-        run: npm config delete prefix && source ~/.nvm/nvm.sh && nvm install v16.15.0 && npm install && npm ci && npm run build
+        run: npm config delete prefix && source ~/.nvm/nvm.sh && nvm install v20.14.0 && npm install && npm ci && npm run build
         working-directory: emulator-run-cmd
       - uses: ./install-sdk
         name: install sdk

diff --git a/emulator-run-cmd/action.yml b/emulator-run-cmd/action.yml
@@ -30,5 +30,5 @@ inputs:
     description: 'be verbose'
     default: 'false'
 runs:
-  using: 'node16'
+  using: 'node20'
   main: 'lib/main.js'
diff --git a/emulator-run-cmd/package-lock.json b/emulator-run-cmd/package-lock.json
diff --git a/emulator-run-cmd/package.json b/emulator-run-cmd/package.json
@@ -25,7 +25,7 @@
   },
   "devDependencies": {
     "@types/jest": "^28.1.4",
-    "@types/node": "^16.10.0",
+    "@types/node": "^20.12.12",
     "jest": "^28.1.2",
     "jest-circus": "^28.1.2",
     "ts-jest": "^28.0.5",

diff --git a/install-sdk/action.yml b/install-sdk/action.yml
@@ -9,5 +9,5 @@ inputs:
     description: 'do you accept all current Android licenses?'
     default: 'yes'
 runs:
-  using: 'node16'
+  using: 'node20'
   main: 'lib/main.js'
diff --git a/install-sdk/package-lock.json b/install-sdk/package-lock.json
diff --git a/install-sdk/package.json b/install-sdk/package.json
@@ -25,7 +25,7 @@
   },
   "devDependencies": {
     "@types/jest": "^28.1.4",
-    "@types/node": "^16.10.0",
+    "@types/node": "^20.12.12",
     "jest": "^28.1.2",
     "jest-circus": "^28.1.2",
     "ts-jest": "^28.0.5",

diff --git a/prepare-for-release.sh b/prepare-for-release.sh
@@ -3,5 +3,5 @@
 set -ex
 
 for i in emulator-run-cmd install-sdk; do
-  (cd $i && docker run -it -v $(pwd):/opt/app -w /opt/app node:16 bash -c 'npm install && npm run build && npm prune --production' && git add -f node_modules lib)
+  (cd $i && docker run -it -v $(pwd):/opt/app -w /opt/app node:20 bash -c 'npm install && npm run build && npm prune --production' && git add -f node_modules lib)
 done