Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Kafka into the services section + cleanup #534

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Jan 5, 2024

  • Move Kafka into the services section
  • Cleanup and consistency with other service sections
  • Add Kafka to requirements table

@nasark Please review.

@Fryguy Fryguy changed the title Kafka service Move Kafka into the services section Jan 5, 2024
@Fryguy
Copy link
Member Author

Fryguy commented Jan 5, 2024

I think this is easier to review with split view and hide whitespace

@Fryguy Fryguy changed the title Move Kafka into the services section Move Kafka into the services section + cleanup Jan 5, 2024
@@ -10,6 +10,7 @@
| Python | 3.8.x | |
| PostgreSQL | 13.x | 14.x |
| Java | 11.x | 19.x |
| Kafka | 3.3.1 | |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what's installed on a fairly recent appliance, so that's the version I picked - we can get more specific later

@miq-bot
Copy link
Member

miq-bot commented Jan 5, 2024

Checked commits Fryguy/guides@2b3bdea~...eb2940b with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@agrare agrare merged commit e4c3bba into ManageIQ:master Jan 5, 2024
1 check passed
github-actions bot pushed a commit to ManageIQ/manageiq.github.io that referenced this pull request Jan 5, 2024
@Fryguy Fryguy deleted the kafka_service branch January 5, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants