Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch the CI matrix from include to exclude #593

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Switch the CI matrix from include to exclude #593

merged 1 commit into from
Sep 24, 2024

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Sep 24, 2024

@jrafanie Please review.

@Fryguy Fryguy added the test label Sep 24, 2024
jrafanie
jrafanie approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you merged so you can get a net negative followup PR. Fine, take your -1 lines. 🤣

@jrafanie jrafanie merged commit 9ce6983 into ManageIQ:master Sep 24, 2024
13 checks passed
@Fryguy Fryguy deleted the invert_ci_matrix branch September 24, 2024 18:28
@kbrock
Copy link
Member

kbrock commented Sep 24, 2024 •
edited
Loading

Quite a few gems I've been using have gone this way
Or just dropped ruby all together from the matrix
and then 1-off'd the older ruby/rails combinations

(yea, I kinda like the include version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie jrafanie approved these changes

Assignees

@jrafanie jrafanie

Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fryguy @kbrock @jrafanie