Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruby rails dependencies (breaking change) #94

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Sep 24, 2024

Use core minimum but allow 7.0/7.1/7.2 since core sets upper limit

Drop end of life rubies and rails and add new versions

Ensure we're testing and supporting community supported
versions.

Drop:

  • ruby 2.7
  • rails 6.0
  • rails 6.1

Add:

  • ruby 3.2
  • ruby 3.3
  • rails 7.1
  • rails 7.2

Note: ruby 3.0 is not difficult to keep maintaining for now but it's on the chopping block.

This should be safe to use as is since the core application sets the rails version.
This will allow us to test with other versions on master.
Gemfile Outdated
"~>7.2.1"
when "7.1"
"~>7.1.4"
else "7.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
else "7.0"
else

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fixed.

@jrafanie jrafanie force-pushed the update_ruby_rails_dependencies branch 2 times, most recently from a8ac3f1 to 04694c7 Compare September 24, 2024 17:42
Ensure we're testing and supporting community supported versions.

Drop:
* ruby 2.7
* rails 6.0
* rails 6.1

Add:
* ruby 3.2
* ruby 3.3
* rails 7.1
* rails 7.2

Note: ruby 3.0 is not difficult to keep maintaining for now but it's on the chopping block.
@jrafanie jrafanie force-pushed the update_ruby_rails_dependencies branch from 04694c7 to 925a6f5 Compare September 24, 2024 18:28
@agrare agrare self-assigned this Sep 24, 2024
@agrare agrare merged commit b1ab77e into ManageIQ:master Sep 24, 2024
12 of 13 checks passed
@jrafanie jrafanie deleted the update_ruby_rails_dependencies branch September 24, 2024 18:37
agrare added a commit that referenced this pull request Sep 30, 2024
Changes:
* Use ruby 3.1 and rails 7 for code coverage [#92]
* Drop end of life rubies and rails and add new versions [#94]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants