Add a CRD field to replace InsecureSkipVerify=true #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
approved these changes
Apr 2, 2024
|
I had the same q as @kbrock. Do we need a setting for users that might need to set verify false? |
|
Checked commit bdunne@485c443 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint **
|
bdunne
changed the title
Fryguy
reviewed
Apr 23, 2024
| customTransport := http.DefaultTransport.(*http.Transport).Clone() | ||
| customTransport.TLSClientConfig = &tls.Config{InsecureSkipVerify: true} | ||
| customTransport.TLSClientConfig = &tls.Config{InsecureSkipVerify: !sslVerify} |
There was a problem hiding this comment.
This is fine, but can we also just not set it? Something like
Suggested change
| customTransport.TLSClientConfig = &tls.Config{InsecureSkipVerify: !sslVerify} | |
| if !sslVerify { | |
| customTransport.TLSClientConfig = &tls.Config{InsecureSkipVerify: !sslVerify} | |
| } |
|
This PR has been effectively backported to |
bdunne
added a commit
to bdunne/manageiq-pods
that referenced
this pull request
Jul 2, 2024
Add a CRD field to replace InsecureSkipVerify=true (cherry picked from commit 5a376e9) # Conflicts: # manageiq-operator/config/crd/bases/manageiq.org_manageiqs.yaml # manageiq-operator/pkg/apis/manageiq/v1alpha1/zz_generated.deepcopy.go
|
Unclean backport... Trying in #1128 but tests aren't passing yet. |
|
@bdunne I moved this to morphy/yes? so it wouldn't get in the way of other backports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test image: docker.io/bdunne/manageiq-operator:ssl_verifyAdd optional CR value
OIDCOAuthIntrospectionSSLVerifyto determine whether or not to verify SSL when fetching the introspection URL. Default to SSLVerify for safety.