Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C and U collection form conversion from HAML to React #8909

Merged
merged 1 commit into from
Sep 12, 2023
Merged

C and U collection form conversion from HAML to React #8909

merged 1 commit into from
Sep 12, 2023

Conversation

anu-jose-ibm
Copy link
Contributor

@anu-jose-ibm anu-jose-ibm commented Sep 4, 2023 •
edited
Loading

old PR - #8791
BEFORE
image

AFTER

Screenshot 2023-09-04 at 12 41 06 PM

@anu-jose-ibm anu-jose-ibm requested a review from a team as a code owner September 4, 2023 05:55
@anu-jose-ibm anu-jose-ibm changed the title c and u form conversion [WIP] C and U collection form conversion Sep 4, 2023
@miq-bot miq-bot added the wip label Sep 4, 2023
@anu-jose-ibm anu-jose-ibm mentioned this pull request Sep 4, 2023
Closed
@anu-jose-ibm anu-jose-ibm force-pushed the c_and_u_collection_form_branch branch from 3ad3897 to 2e3ae36 Compare September 4, 2023 06:48
@jeffibm jeffibm self-assigned this Sep 5, 2023
@jeffibm jeffibm changed the title [WIP] C and U collection form conversion [WIP] C and U collection form conversion from HAML to React Sep 5, 2023
@anu-jose-ibm anu-jose-ibm force-pushed the c_and_u_collection_form_branch branch 3 times, most recently from b1a40f1 to e3760fe Compare September 7, 2023 04:28
@anu-jose-ibm anu-jose-ibm changed the title [WIP] C and U collection form conversion from HAML to React C and U collection form conversion from HAML to React Sep 7, 2023
@miq-bot miq-bot removed the wip label Sep 7, 2023
@anu-jose-ibm anu-jose-ibm force-pushed the c_and_u_collection_form_branch branch 2 times, most recently from ea7c69f to 66fb4f4 Compare September 11, 2023 05:57
@anu-jose-ibm anu-jose-ibm force-pushed the c_and_u_collection_form_branch branch 3 times, most recently from 22b1218 to 2751540 Compare September 11, 2023 06:34
DavidResende0
DavidResende0 approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@DavidResende0 DavidResende0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it LGTM but one quick change I would make is that typically for timezone dropdowns, we use a searchable select because there are so many options in the list and it takes over the page when trying to pick an item. The My Settings page has an example of this if you need it.

image
image

@anu-jose-ibm anu-jose-ibm force-pushed the c_and_u_collection_form_branch branch from 2751540 to 274d8b1 Compare September 12, 2023 04:42
@anu-jose-ibm anu-jose-ibm force-pushed the c_and_u_collection_form_branch branch from 274d8b1 to 7e3bd4f Compare September 12, 2023 04:58
@anu-jose-ibm anu-jose-ibm force-pushed the c_and_u_collection_form_branch branch from 7e3bd4f to f18225a Compare September 12, 2023 05:34
@miq-bot
Copy link
Member

miq-bot commented Sep 12, 2023

Checked commit anu-jose-ibm@f18225a with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@jeffibm jeffibm merged commit 2445219 into ManageIQ:master Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidResende0 DavidResende0 DavidResende0 approved these changes

@jeffibm jeffibm jeffibm approved these changes

Assignees

@jeffibm jeffibm

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anu-jose-ibm @miq-bot @DavidResende0 @jeffibm