Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Automate Method Form Conversion from Angular to REACT #9047

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amalvijayan03
Copy link
Contributor

@amalvijayan03 amalvijayan03 commented Jan 22, 2024

Tasks to be completed

  • Convert the initial type selector page.
  • Create a single schema for all forms.
  • Include input parameter component.
  • Add input parameter modal popup.
  • Integrate code mirror component for built in method.
  • Add embedded method popup modal
  • Pass input parameters from modal form to data table
  • Pass the actual values to the form.
  • Add styling by introducing accordion
  • input-parameters
  • code-mirror
  • expression-editor
  • 1. Anisble Job Job Template
  • 2. Ansible Tower Workflow Template
  • 3. Built-in
  • 4.Inline
  • 5.Expression
  • 6.Playbook
  • New Record form submit action
  • Populate values in Edit page
  • 1. Anisble Job Job Template
  • 2. Ansible Tower Workflow Template
  • 3. Built-in
  • 4.Inline
  • 5.Expression
  • 6.Playbook
  • Edit Record form submit action
image image

@amalvijayan03 amalvijayan03 requested a review from a team as a code owner January 22, 2024 12:55
@miq-bot miq-bot added the wip label Jan 22, 2024
@jeffibm jeffibm self-assigned this Jan 22, 2024
@amalvijayan03
Copy link
Contributor Author

Integrated the coder mirror for the inline field.
Added the input parameters modal and input parameters table.
Finalised the schema by combining schema into a single file.
image

@amalvijayan03 amalvijayan03 force-pushed the automate-method-form-conversion branch from 2e46f47 to 7995404 Compare January 29, 2024 14:34
@amalvijayan03 amalvijayan03 force-pushed the automate-method-form-conversion branch from edd20a0 to 17e2b42 Compare February 22, 2024 12:22
@jeffibm
Copy link
Member

jeffibm commented Feb 23, 2024

Updates as of 22 feb 2024

conversion-progress-new.mov

@ManageIQ ManageIQ deleted a comment from amalvijayan03 Feb 23, 2024
@jeffibm
Copy link
Member

jeffibm commented Feb 29, 2024

hey @amalvijayan03 - #9059 (comment)

@amalvijayan03
Copy link
Contributor Author

amalvijayan03 commented Mar 4, 2024

Before

Add new method

POST:  miq_ae_class/add_update_method/new?button=add,
{
  class_id: 20170, // hidden
  language: 'ruby', // hidden
  scope: 'instance', // hidden
  location: 'ansible_job_template', // hidden
  name: 'name001', // Name
  display_name: 'name00011', // Display Name
  manager_id: 53, // Provider
  ansible_template_id: 347, // Job Template
  repository_id: null, 
  playbook_id: null,
  credential_id: null,
  vault_credential_id: null,
  verbosity: null,
  become_enabled: false,
  execution_ttl: 3, // Max TTL (mins)
  log_output: 'on_error',
  hosts: 'localhost', // Hosts
  extra_vars: [['aaa', 1, 'string'], ['bbb', 'bbbb', 'string']]
};

@amalvijayan03
Copy link
Contributor Author

amalvijayan03 commented Mar 4, 2024

Edit Page

GET: /miq_ae_class/x_button/20170?pressed=miq_ae_method_edit,
{
miq_grid_checks: aem-60053
select-row-60053: on
}
GET: /miq_ae_class/method_form_fields/60053?location=ansible_job_template,
{
location: ansible_job_template
}

@jeffibm
Copy link
Member

jeffibm commented Mar 4, 2024

update as of March 4, 2024

conver-progress-4.mov

@jeffibm jeffibm changed the title [WIP]Automate Method Form Conversion From HAML to REACT [WIP]Automate Method Form Conversion from Angular to REACT Mar 6, 2024
@amalvijayan03 amalvijayan03 force-pushed the automate-method-form-conversion branch from cb9cf36 to 174d0b3 Compare March 12, 2024 09:12
@miq-bot
Copy link
Member

miq-bot commented Mar 12, 2024

Checked commit amalvijayan03@174d0b3 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
3 files checked, 6 offenses detected

app/controllers/miq_ae_class_controller.rb

app/views/miq_ae_class/_method_form.html.haml

  • 💣 💥 🔥 🚒 - Line 0 - Couldn't process the file for linting. RuntimeError: Line 1 should be followed by indentation. This might actually work in Haml, but it's almost a bug that it does. haml-lint cannot process.
  • ⚠️ - Line 5 - Line is too long. [97/80]
  • ⚠️ - Line 6 - Line is too long. [98/80]

@miq-bot miq-bot added the stale label Jun 17, 2024
@miq-bot
Copy link
Member

miq-bot commented Jun 17, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Jul 29, 2024

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Nov 1, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants