Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Search bar component in Cloud Tenant module #9229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dhamo1107
Copy link

This PR enhances the search functionality in Compute -> Clouds -> Tenant -> (admin) -> admin (Cloud Object Store Containers, Images, Instances, Security Groups, Cloud Networks, Cloud Subnets, Network Ports, Cloud Volumes).

Changes Included:

  1. Reused SearchBar Component:
    The SearchBar component is reused with the advanced_search parameter set to false to simplify the search process.

  2. Application Controller Updates:
    In the get_view_process_search_text method of application_controller.rb, the logic has been updated to handle the @display instance variable.

  3. CSS Adjustments:
    Added CSS rules to ensure the search bar appears correctly positioned on the right side of the screen.

Impact:
These changes ensure that the search bar functionality works seamlessly across different views, including images, instances, security groups, cloud volumes, and other entities under the Tenant in the Clouds menu.

Testing:
Verified that the search bar works correctly for all Cloud Tenant display in the UI. But not executed the Rspec test cases.

Before:
Screenshot 2024-07-17 152412

After:
Screenshot 2024-07-17 153143

@Dhamo1107 Dhamo1107 requested a review from a team as a code owner July 25, 2024 05:43
@miq-bot miq-bot added the wip label Jul 25, 2024
@miq-bot
Copy link
Member

miq-bot commented Jul 25, 2024

Checked commit Dhamo1107@7428b3c with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@GilbertCherrie GilbertCherrie self-assigned this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants