[WIP] Convert role form from haml to React and add cypress testing #9248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liu-samuel
force-pushed
the
role-form-conversion
branch
3 times, most recently
from
5e7b5ea
to
435b95f
Compare
Fryguy
reviewed
Aug 14, 2024
package.json
Outdated
| @@ -71,6 +72,7 @@ | |||
| "eonasdan-bootstrap-datetimepicker": "~4.17.49", | |||
| "es6-shim": "~0.35.3", | |||
| "history": "^4.7.2", | |||
| "i": "^0.3.7", | |||
Fryguy
reviewed
Aug 14, 2024
package.json
Outdated
| @@ -81,12 +83,14 @@ | |||
| "moment-duration-format": "~2.2.2", | |||
| "moment-strftime": "~0.5.0", | |||
| "moment-timezone": "~0.5.40", | |||
| "npm": "^10.8.2", | |||
There was a problem hiding this comment.
Not sure why this is needed either?
|
My only other concern is the checkbox tree may not be carbon-compatible? Even so, it's great there's a react component already out there. |
liu-samuel
force-pushed
the
role-form-conversion
branch
from
5871655
to
189efbc
Compare
liu-samuel
force-pushed
the
role-form-conversion
branch
from
189efbc
to
0f17df2
Compare
|
Checked commit liu-samuel@0f17df2 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint app/controllers/ops_controller/ops_rbac.rb
app/views/ops/_rbac_role_details.html.haml
|
|
This pull request is not mergeable. Please rebase and repush. |
Fryguy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts user role form from haml to React and add cypress testing
Old:
New:
Related: ManageIQ/manageiq#23153