Show Terraform Template stack stdout #9285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
putmanoj
force-pushed
the
show-terraform-stdout
branch
from
2926d6b to
569643d
Compare
putmanoj
force-pushed
the
show-terraform-stdout
branch
from
5e664b0 to
7a65c3e
Compare
agrare
reviewed
Oct 21, 2024
| @@ -3,6 +3,10 @@ | |||
| %ul.nav.nav-tabs{'role' => 'tablist'} | |||
| = miq_tab_header("details") do | |||
| = _("Details") | |||
| - if @record.type == "ServiceTerraformTemplate" | |||
| - stack = @record.try(:stack, "Provision") | |||
There was a problem hiding this comment.
This is extremely close to - provision_job = @record.try(:job, "Provision") below, I wonder if we could drop the "Is this an AnsiblePlaybook service or is it a terraform service" and instead say "does the provision job support stdout" generally
agrare
reviewed
Oct 21, 2024
Comment on lines
+36
to
+41
|
|
||
| - if @record.type == "ServiceTerraformTemplate" | ||
| = miq_tab_content("output", 'default', :class => 'cm-tab') do | ||
| - if stack | ||
| = react('ServiceDetailStdout', { :taskid => stack.raw_stdout_via_worker(User.current_user&.userid, 'html')}); | ||
|
|
There was a problem hiding this comment.
My only question is if this could be more like the Ansible examples below versus having the miq_tab_header up above.
|
Is it possible to add specs covering this new code? Especially if we start refactoring this to be more generic it would be good to have existing specs in place. |
agrare
approved these changes
Oct 21, 2024
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Oct 22, 2024
Show Terraform Template stack stdout (cherry picked from commit d12d720)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dependant on ManageIQ/manageiq-providers-embedded_terraform#78
With this change, separate tab added to show standard output from the terraform cli run job.
Additional changes