Remove copy and paste button for automation simulation #9308
Conversation
| @@ -1,12 +1,2 @@ | |||
| class ApplicationHelper::Toolbar::MiqAeToolsSimulateCenter < ApplicationHelper::Toolbar::Basic | |||
There was a problem hiding this comment.
If there's nothing left in this toolbar, is it possible to delete the toolbar?
There was a problem hiding this comment.
I tried doing that, but the application was saying it expected the class definition for some reason. I was trying to find where that was happening but wasn't able to. Do you know where that might be?
There was a problem hiding this comment.
Looks like
There was a problem hiding this comment.
I don't really understand how it gets there though - do you have a stack track when it fails when you delete it?
There was a problem hiding this comment.
There's no stack trace in my terminal, just this error message shows up on my UI
There was a problem hiding this comment.
you should see a stack trace in possibly the development.log or the evm.log
There was a problem hiding this comment.
Hmm i don't see anything that relates to the toolbar in the evm.log, just that it connects to the database
[----] I, [2024-11-11T15:55:34.662273#18468:5ec4] INFO -- evm: MIQ(ManageIQ::Session.configure_session_store) Using session_store: ActionDispatch::Session::MemCacheStore
[----] I, [2024-11-11T15:55:34.820424#18468:5ec4] INFO -- evm: MIQ(Vmdb::Initializer.init) Initializing Application: Program Name: bin/rails, PID: 18468, ENV['EVMSERVER']:
[----] I, [2024-11-11T15:55:34.820474#18468:5ec4] INFO -- evm: MIQ(Vmdb::Initializer.log_db_connectable) Successfully connected to the database.
[----] I, [2024-11-11T15:55:35.881939#18468:5ec4] INFO -- evm: MIQ(Vmdb::Loggers.apply_config) Log level for azure has been changed to [WARN]
[----] I, [2024-11-11T15:55:35.882076#18468:5ec4] INFO -- evm: MIQ(Vmdb::Loggers.apply_config) Log level for vim has been changed to [WARN]
[----] I, [2024-11-11T15:55:35.882171#18468:5ec4] INFO -- evm: MIQ(Vmdb::Initializer.init) Initializing Application: Program Name: bin/rails, PID: 18468, ENV['EVMSERVER']:
[----] I, [2024-11-11T15:55:35.882213#18468:5ec4] INFO -- evm: MIQ(Vmdb::Initializer.log_db_connectable) Successfully connected to the database.
| N_('Copy'), | ||
| :url => "resolve", | ||
| :url_parms => "?button=copy", | ||
| :klass => ApplicationHelper::Button::AeCopySimulate), |
There was a problem hiding this comment.
Do you see any other usages of this class? If not, can we delete it?
There was a problem hiding this comment.
I searched and I think you can delete all references to AeCopySimulate: https://github.com/search?q=org%3AManageIQ%20AeCopySimulate&type=code
liu-samuel
force-pushed
the
remove-automate-copy-paste
branch
from
c14b016 to
079d068
Compare
| - copied_target_class = session[:resolve_object][:new][:target_class] | ||
| - current_target_class = @edit[:new][:target_class] | ||
| - if copied_target_class == current_target_class | ||
| = link_to({:action => "resolve", :button => "paste"}, |
There was a problem hiding this comment.
There's probably also a "resolve" action in the simulation controller that can be removed as well. Might involve some more searching though.
There was a problem hiding this comment.
def resolve
custom_button_redirect = params[:button] == 'simulate' || params[:simulate] == 'simulate'
assert_privileges(custom_button_redirect ? 'ab_button_simulate' : 'miq_ae_class_simulation')
@explorer = true
@breadcrumbs = []
drop_breadcrumb(:name => _("Resolve"), :url => "/miq_ae_tools/resolve")
@lastaction = "resolve"
@right_cell_text = _("Simulation")
case params[:button]
when "throw", "retry" then resolve_button_throw
when "copy" then resolve_button_copy
when "paste" then resolve_button_paste
when "simulate" then resolve_button_simulate
else resolve_button_reset_or_none
end
end
I think this is what the resolve is referring to, so I should be able to remove the copy and paste cases but not the others since they deal with the actual simulation
liu-samuel
force-pushed
the
remove-automate-copy-paste
branch
from
079d068 to
11e0659
Compare
|
LGTM - @GilbertCherrie Please review. |
Old:
New:
