Making tags more readable #9320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liu-samuel
force-pushed
the
tag-list-customer-case
branch
from
84d91cb to
14fd627
Compare
Fryguy
reviewed
Dec 11, 2024
|
|
||
| let text; | ||
| if (Array.isArray(value)) { | ||
| text = value.join('\n'); |
There was a problem hiding this comment.
Instead of \n, should we be using <br> ? I'm kind of surprised that \n works.
There was a problem hiding this comment.
I tried using
but it didn't seem to work. I might be doing it wrong but when I do text = value.join('<br>'); the
shows up as actual text instead of a line break
GilbertCherrie
approved these changes
Dec 17, 2024
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Jan 7, 2025
Making tags more readable (cherry picked from commit 1f5c90e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old:
New:
