Fixes 500 error occurred during refreshing of a provider instance #9353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error occurs only in cases when refresh is done 'after' a reconfigure operation on the provider instance. It was rendering the _resize partial due to a pre-existing value in the @sb[:action] Fixes rspec failures
elsamaryv
force-pushed
the
ivt-server-err-fix-2848
branch
from
7e6c969 to
e3a6d57
Compare
|
@miqbot assign @Fryguy |
|
@elsamaryv is it possible to add a spec test covering this case? |
agrare
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Test fails without the fix to application_controller/explorer, 👍 LGTM
@GilbertCherrie this does feel pretty fragile, I see we do clear out @record and @sb[:action] in a number of other places (e.g. @sb[:action] = @edit = @record = nil), if this is required I wonder if a more general approach to clearing out stale values when switching between states would be less prone to error and not require each method to do it manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue- An internal server error occurs during refresh('Refresh Relationships and Power States') of a provider instance. The error occurs only in cases when refresh is done 'after' a reconfigure ('Reconfigure selected instance') operation on the provider instance.
Observation- This was happening because it was rendering the _resize partial due to a pre-existing value in the @sb[:action].
Steps to reproduce the behavior:
Before the fix -
After the fix -
@miq-bot add-label bug
@miq-bot add-reviewer @GilbertCherrie