Enhance select accordion item

[asirvadAbrahamVarghese]

PR to address the issue with selectAccordionItem command as mentioned in #9699 (comment)

Test looks fine even with catalog setup using factories:

Command queue also looks clean:

• Intercept & wait for tree_autoload when expand button(fa-angle-right) is clicked
• Query again the whole expanded accordion to get latest DOM object
• then continue to next node from current index, not from starting
• Intercept and wait for tree_select when target node is clicked

And when no tree_autoload call occurs during expansion (span.fa-angle-right is the expand element), the command runs normally without re-querying the DOM or introducing waits:

@miq-bot add-label cypress
@miq-bot add-label refactoring
@miq-bot assign @jrafanie

[asirvadAbrahamVarghese]

After checking how the UI behaves, I noticed that tree_autoload fires whenever a node is expanded. When this happens, the accordion tree refreshes and the DOM gets updated. Because of that, I’ve updated it in a way we only re-query the DOM when both a node expansion occurs and tree_autoload is triggered. This avoids re-fetching the DOM every time expandAndClickPath runs unnecessarily.

[jrafanie]

Ok, this solves 1 of the problems I was seeing. I was able to get the test working. I'll merge as is and I'll post another comment where I'm still seeing a slight problem that can be handled in a followup.

[jrafanie]

@asirvadAbrahamVarghese For the follow up issue, I converted the existing copy_catalog test directly to use factories and that led to using the selectAccordionItem back to back because that's what it did previously.

The second selectAccordionItem fails to find the desired node, I suspect it's because we're not starting at the top level node. If I remove the first selectAccordionItem call, "unassigned", the test works. See the new commit here: #9699

Note, in this test it makes sense remove the redundant selectAccordionItem call, but I do wonder if there's a general bug if you try to do selectAccordionItem calls back to back.

    cy.selectAccordionItem([
      ALL_CATALOG_ITEMS_ACCORDION_ITEM,
      UNASSIGNED_ACCORDION_ITEM,
    ]);

    cy.selectAccordionItem([
      ALL_CATALOG_ITEMS_ACCORDION_ITEM,
      UNASSIGNED_ACCORDION_ITEM,
      CATALOG_ITEM_NAME,
    ]);