Merge pull request #23035 from agrare/fix_embedded_ansible_playbook_z…

…ero_min_timeout

Don't send a 0.minute timeout for EmbeddedAnsible Playbook run if execution_ttl is not passed

app/models/manageiq/providers/embedded_ansible/automation_manager/playbook.rb

@@ -18,8 +18,8 @@ def run(vars = {}, _userid = nil)
     credentials = collect_credentials(vars)
 
     kwargs = {:become_enabled => vars[:become_enabled]}
-    kwargs[:timeout]   = vars[:execution_ttl].to_i.minutes
-    kwargs[:verbosity] = vars[:verbosity].to_i if vars[:verbosity].present?
+    kwargs[:timeout]   = vars[:execution_ttl].to_i.minutes if vars[:execution_ttl].present?
+    kwargs[:verbosity] = vars[:verbosity].to_i             if vars[:verbosity].present?
 
     workflow.create_job({}, extra_vars, playbook_vars, vars[:hosts], credentials, **kwargs).tap(&:signal_start)
   end

spec/models/manageiq/providers/embedded_ansible/automation_manager/playbook_spec.rb

@@ -41,6 +41,13 @@
       expect(job.options[:verbosity]).to eq(5)
     end
 
+    it "defaults to timeout 1.hour with execution_ttl is not passed" do
+      job = playbook.run
+
+      expect(job).to be_a(ManageIQ::Providers::AnsiblePlaybookWorkflow)
+      expect(job.options[:timeout]).to eq(1.hour)
+    end
+
     it "passes become_enabled to the job when specified" do
       job = playbook.run(:become_enabled => true)