Update deployment logic for settings changes #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bdunne
commented
Nov 22, 2023
bdunne
commented
- Sync up deployments from the running bot
- Change the settings location to come from a secret now that the defaults are checked in and only secret values are stored in the yml
bdunne
force-pushed
the
settings_changes
branch
from
5fac70c
to
b88dcbc
Compare
|
Checked commit bdunne@b88dcbc with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint **
|
Fryguy
approved these changes
Nov 22, 2023
Fryguy
reviewed
Nov 22, 2023
templates/bot.yaml
Outdated
Comment on lines
140
to
144
| readinessProbe: | ||
| failureThreshold: 3 | ||
| initialDelaySeconds: 60 | ||
| periodSeconds: 10 | ||
| successThreshold: 1 | ||
| tcpSocket: | ||
| port: 5432 | ||
| timeoutSeconds: 1 |
There was a problem hiding this comment.
Original code before the reorder was:
Suggested change
| readinessProbe: | |
| failureThreshold: 3 | |
| initialDelaySeconds: 60 | |
| periodSeconds: 10 | |
| successThreshold: 1 | |
| tcpSocket: | |
| port: 5432 | |
| timeoutSeconds: 1 | |
| readinessProbe: | |
| initialDelaySeconds: 60 | |
| tcpSocket: | |
| port: 5432 |
bdunne
force-pushed
the
settings_changes
branch
from
b88dcbc
to
167d2d3
Compare
Fryguy
reviewed
Nov 22, 2023
| name: postgresql | ||
| ports: | ||
| - containerPort: 5432 | ||
| protocol: TCP |
There was a problem hiding this comment.
Technically the protocol was added
There was a problem hiding this comment.
I think we should keep these
bdunne
force-pushed
the
settings_changes
branch
from
167d2d3
to
eeded37
Compare
Fryguy
reviewed
Nov 22, 2023
| persistentVolumeClaim: | ||
| claimName: bot-postgres-pvc | ||
| - configMap: | ||
| defaultMode: 420 |
There was a problem hiding this comment.
All of these defaultMode look new, so I think we can drop them.
Fryguy
reviewed
Nov 22, 2023
| ports: | ||
| - containerPort: 6379 | ||
| protocol: TCP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.