Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Volume tag accept decimals #185

Open
Roshri opened this issue Jul 15, 2023 · 8 comments
Open

Make Volume tag accept decimals #185

Roshri opened this issue Jul 15, 2023 · 8 comments

Comments

@Roshri
Copy link

Roshri commented Jul 15, 2023

Is your feature request related to a problem? Please describe.
I have some volumes for specific manga that have decimal on them, and Manga Manager doesn't accept the dot (.) separator to represent it on the volume tag.

Example of one series
image

Describe the solution you'd like
Ideally, I'd like to have it so I can have the decimal in between integers, so 10.5 would be between 10 and 11 when displaying in Kavita. (And not whatever fuckery w10 does where it shows the decimal first lol)

@ThePromidius
Copy link
Member

Related: #174

@ThePromidius
Copy link
Member

Technically float values are not supported by comicinfo schema 🤔
Thougths on this?
yeah works on kavita i guess.... but trying to stay consistent.
Also what's the point in having decimal values? This is a personal query. How does that work?

@Roshri
Copy link
Author

Roshri commented Sep 21, 2023

Never saw your reply, sorry for the late response. I have some manga that releases bonus volumes bundled with limited edition of the physical book, which are commonly labelled as vol XX.5 as they are intended to be read after said volume. Currently, specials can cover for this in a limited manner since you have to switch tabs and remember where you're supposed to read the .5 volume

@majora2007
Copy link
Contributor

Perhaps we can raise a spec change request supporting float volumes and then move forward with implementation, regardless of if it merges or not.

@Roshri would you be able to provide some official Volume x.5 samples?

@Roshri
Copy link
Author

Roshri commented Jan 9, 2024

I can email you the .cbz for vol 10.5 of the series I pictured above. It's a small ilustration book with a short story, it came bundled with vol 10

@majora2007
Copy link
Contributor

Roshri, would you be willing to open a spec enhancement here?
https://github.com/anansi-project/comicinfo/issues

I'm not saying it will get approved, but it is the first step to allowing MM to change against the spec (like we did with LocalizedSeries in MM/Kavita)

@majora2007
Copy link
Contributor

Just following up @Roshri (or anyone interested), nothing has been opened requesting this on the spec.

@Roshri
Copy link
Author

Roshri commented Feb 11, 2024

I forgot, I'm on vacation right now, I'll open it when I come back! Thanks for the reminder

edit: just created the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants