Make VariantOfVectors a public type of PointData, add setData overload #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasKroes
approved these changes
Feb 8, 2024
Moved the definition of the type `VariantOfVectors` from the private to the (first) public section of PointData. Added an extra `PointData::setData` overload that allows specifying such a variant as `data` parameter. Suggested by Jeroen Eggermont.
N-Dekker
force-pushed
the
feature/Make-VariantOfVectors-public
branch
from
60691f8
to
364329b
Compare
|
FYI, the force-push that I just did was just to include the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the definition of the type
VariantOfVectorsfrom the private to the (first) public section of PointData. Added an extraPointData::setDataoverload that allows specifying such a variant asdataparameter.Suggested by Jeroen Eggermont.