-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake find package #619
Merged
Merged
CMake find package #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbvis
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ThomasKroes
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on Win11
Nice, thanks for testing this! :) |
alxvth
force-pushed
the
feature/CmakeFindPackage
branch
from
July 15, 2024 07:41
636d491
to
4e8937f
Compare
This was referenced Jul 15, 2024
This was referenced Jul 30, 2024
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installs
ManiVaultTargets.cmake
,ManiVaultConfig.cmake
and related cmake packages files such that ManiVault can be found usingfind_package
.The ExamplePlugins, BinIO and SpectralViewer plugins show how this looks from a plugins perspective:
The variables
ManiVault_INCLUDE_DIR
,ManiVault_INSTALL_DIR
,ManiVault_LIB_DIR
,ManiVault_LINK_LIBS
andManiVault_VERSION
are automatically set inCONFIG
mode.For CMake to find the package, you need to define a path
ManiVault_DIR
that point to where theManiVaultConfig.cmake
lies. After building the core, this will beMV_INSTALL_DIR/cmake/mv
, i.e. will now be a cmake folder next to the Debug, Release, etc. config folder in the install directory.Since ManiVault is installed into a bit of a non-standard directory layout, I couldn't yet figure out how to set
INTERFACE_INCLUDE_DIRECTORIES
correctly, meaning that thetarget_include_directories
have to be set explicitly. (Ideally only thetarget_link_libraries
should be necessary).You can also specify versions:
When using the core and plugins in a project with
add_subdirectory
(like in the DevBundle), the find package command must not use theREQUIRED
argument.TODO: