-
Couldn't load subscription status.
- Fork 2.5k
Improve docs and typings for mobject_update_utils, and add examples for always(), f_always() and cycle_animation()
#3976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…les for always and f_always
…pdate-utils-typings
mobject_update_utils, and add examples for always and f_alwaysmobject_update_utils, and add examples for always(), f_always() and cycle_animation()
mobject_update_utils, and add examples for always(), f_always() and cycle_animation()mobject_update_utils, and add examples for always(), f_always() and cycle_animation()
|
I'll mark this as a draft for now. PR #4382 was submitted recently, which made me notice some flaws in the current implementation. Back in the time, I didn't stop ignoring MyPy errors for |
Overview: What does this pull request change?
always(),cycle_animation()andassert_is_mobject_method().Parameters,ReturnsandRaisessections.always(),f_always()andcycle_animation().MobjectTTypeVarin order to get better typings for theMobjects returned by functions such asalways_redraw(). For example, if the lambda function insidealways_redraw()returns aBrace, theMobjectreturned byalways_redraw()is now recognized as aBraceand, as such, autocompletion includesBracemethods and attributes.Callables were missing parameter and return types.**kwargsfromturn_animation_into_updater()andcycle_animation().Links to added or changed documentation pages
https://manimce--3976.org.readthedocs.build/en/3976/reference/manim.animation.updaters.mobject_update_utils.html
Reviewer Checklist