- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2.5k
          Add type annotations to opengl_mobject.py
          #4398
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 12 commits
      Commits
    
    
            Show all changes
          
          
            46 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      1cd1550
              
                feat(manim.mobject.opengl): added type annotations for `opengl_compat…
              
              
                RBerga06 12c9bdf
              
                feat(manim.mobject.opengl): typed almost all attribute definitions in…
              
              
                RBerga06 8d0a47d
              
                feat(manim.mobject.opengl): typed more methods for `OpenGLMobject`
              
              
                RBerga06 a12e419
              
                fix(manim.mobject.opengl): import `override` from `typing_extensions`
              
              
                RBerga06 bc1fe38
              
                fix(manim.mobject.opengl): import `Never` from `typing_extensions`
              
              
                RBerga06 0f119e5
              
                feat(manim.utils.config_ops): made `_Data` descriptor generic, to all…
              
              
                RBerga06 a1d8e3d
              
                fix(mypy.ini): don't ignore `manim.mobject.opengl.opengl_mobject`
              
              
                RBerga06 59d1fac
              
                fix(manim.utils.config_ops): import `TypeVar` from `typing_extensions…
              
              
                RBerga06 9472b06
              
                feat(manim.mobject.opengl.opengl_mobject): Type checked more methods …
              
              
                RBerga06 40dc43f
              
                fix(manim.mobject.opengl.opengl_mobject): Fix a typo in `OpenGLMobjec…
              
              
                RBerga06 cb2a1a4
              
                feat(manim.mobject.opengl.opengl_mobject): Typed more methods in `Ope…
              
              
                RBerga06 cfd29e6
              
                feat(manim.mobject.opengl.opengl_mobject): Moved `overload`s inside a…
              
              
                RBerga06 2be97ff
              
                feat(manim.mobject.opengl.opengl_mobject): Added type annotations for…
              
              
                RBerga06 f35c8a8
              
                Revert "feat(manim.mobject.opengl): added type annotations for `openg…
              
              
                RBerga06 2909380
              
                fix(OpenGLMobject): defined `get_array_attrs` method (and typed `_ori…
              
              
                RBerga06 e6d1838
              
                feat(manim.mobject.opengl.opengl_mobject): Added type annotations for…
              
              
                RBerga06 2de7ec7
              
                feat(manim.mobject.opengl.opengl_mobject): Added type annotations to …
              
              
                RBerga06 08c9dff
              
                fix(manim.mobject.opengl.opengl_mobject): fix failing tests
              
              
                RBerga06 5d5de9a
              
                fix(OpenGLMobject): default implementation of `pointwise_become_parti…
              
              
                RBerga06 f3d8aea
              
                feat(OpenGLMobject): added `type: ignore[no-untyped-call]` for calls …
              
              
                RBerga06 deb2b74
              
                feat(OpenGLMobject): annotated shader-related `ClassVar`s
              
              
                RBerga06 09d671a
              
                feat(OpenGLMobject): typed several `**kwargs` and added `type: ignore…
              
              
                RBerga06 47ffd40
              
                feat(OpenGLMobject): typed more `**kwargs` and fixed `set_color` argu…
              
              
                RBerga06 fcb022d
              
                feat(OpenGLMobject): Added more type annotations.
              
              
                RBerga06 2d7fa4c
              
                feat(OpenGLMobject): Typed `OpenGLMobject.uniforms` and `OpenGLMobjec…
              
              
                RBerga06 1aee8aa
              
                fix(OpenGLMobject): fix tests
              
              
                RBerga06 a380bd8
              
                fix(OpenGLGroup): annotate `**kwargs`
              
              
                RBerga06 524e0cc
              
                fix(OpenGLPoint): annotate `**kwargs`
              
              
                RBerga06 c43ae87
              
                Merge branch 'main' into typing-opengl
              
              
                RBerga06 e04e5cb
              
                fix(OpenGLPoint): corrected `**kwargs` and removed two `type: ignore`s
              
              
                RBerga06 0d977ae
              
                fix(OpenGLPoint): removed `# type: ignore[no-untyped-call]`s
              
              
                RBerga06 372722d
              
                fix(ci): import `Self` from `typing_extensions` rather than `typing`.
              
              
                RBerga06 8148f37
              
                fix(ci): import `TypeAlias` from `typing_extensions` rather than `typ…
              
              
                RBerga06 208aba4
              
                feat(OpenGLMobject): make use of PEP 728.
              
              
                RBerga06 69b96c6
              
                fix(ci): update `typing-extensions` requirement to the first version …
              
              
                RBerga06 72a28b6
              
                fix(OpenGLMobject): avoid variable redefinitions in the `arrange_in_g…
              
              
                RBerga06 f874f12
              
                fix(mypy.ini): remove unused changes to `mypy` configuration.
              
              
                RBerga06 0bcbae0
              
                fix(OpenGLMobject): use different symbols for the two `updater` varia…
              
              
                RBerga06 aea6fe8
              
                Revert "fix(ci): update `typing-extensions` requirement to the first …
              
              
                RBerga06 9f7b84a
              
                fix(OpenGLMobject): remove `TypedDict`s and switch to the less precis…
              
              
                RBerga06 5434545
              
                Merge branch 'main' into typing-opengl
              
              
                RBerga06 2c3f777
              
                Merge branch 'main' into typing-opengl
              
              
                RBerga06 2baa3b0
              
                Handle three no-any-return issues.
              
              
                henrikmidtiby bbf215a
              
                Removed the slash divider in function parameters
              
              
                henrikmidtiby 7447799
              
                Removed the slash divider in function parameters
              
              
                henrikmidtiby e11756f
              
                Keep a single slash divider - to make return types match
              
              
                henrikmidtiby File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.