Fix AttributeError: NumberLine object has no attribute 'default_numbers_to_display' #4414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs_to_display' - Add missing default_numbers_to_display() method to NumberLine class - Method returns tick range excluding numbers in numbers_to_exclude list - Resolves issue where get_number_mobjects() would fail with AttributeError - Fixes ManimCommunity#4244
for more information, see https://pre-commit.ci
|
收到了！谢谢！
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #4244 where calling get_number_mobjects() on a NumberLine object would raise an AttributeError because the default_numbers_to_display() method was missing.
Changes Made
Testing
Fixes
Closes #4244