Fix caching issue with always_redraw causing incorrect object placement #4416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #4160 where rendering a scene multiple times with caching enabled results in incorrect placement of objects that use always_redraw with ValueTrackers.
Problem Analysis
The issue was a variation of #550 where cached animations affected the global timestamp. When caching is used:
Root Cause
In the OpenGL renderer play method, when animations were skipped due to caching, the code would bypass scene.play_internal() but still increment self.time. This left all ValueTrackers and animated mobjects in their initial state while the scene time was at the end state.
Changes Made
Testing
Fixes
Closes #4160
Example Usage
The following code (from the original issue) should now render consistently on multiple runs with caching enabled: