Skip to content

Conversation

@jplatte
Copy link
Contributor

@jplatte jplatte commented Dec 31, 2025

No description provided.

Copy link
Owner

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future PRs please don't move APIs around, it makes it harder to review.

@Manishearth Manishearth merged commit 6ef61c3 into Manishearth:master Dec 31, 2025
6 checks passed
@jplatte
Copy link
Contributor Author

jplatte commented Dec 31, 2025

I only moved from implicitly-T: Sized impl blocks to T: ?Sized impl blocks. Though I'm happy to redo this, e.g. by merging the impl blocks into one with T: ?Sized + T: Sized bounds on the relevant functions.

@jplatte jplatte deleted the offset-qsized branch December 31, 2025 18:06
@Manishearth
Copy link
Owner

@jplatte No, your PR also moved some functions around in the file, please look at the diff. Perhaps you have some automatic tooling involved that ran without you realizing.

@jplatte
Copy link
Contributor Author

jplatte commented Dec 31, 2025

No, I made all those changes myself and they did involve moving functions between different impl blocks. I already re-reviewed after your first comment. Which off the two changed files did you mean?

@Manishearth
Copy link
Owner

Ah, I see what happened. That makes sense, things were moved between impl blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants