Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add funcionality for config editing #41

Closed
ivyleavedtoadflax opened this issue Nov 5, 2022 · 3 comments · Fixed by #47
Closed

Add funcionality for config editing #41

ivyleavedtoadflax opened this issue Nov 5, 2022 · 3 comments · Fixed by #47
Labels
enhancement New feature or request

Comments

@ivyleavedtoadflax
Copy link
Contributor

It would be great to have some functionality to support the editing of the config JSONs.

@nsorros nsorros added the enhancement New feature or request label Nov 18, 2022
@nsorros
Copy link
Contributor

nsorros commented Nov 18, 2022

Is that similar to #8 ? Could you expand on the feature?

@ivyleavedtoadflax
Copy link
Contributor Author

Yes similar to #8, but also we don't actually check anywhere that the config json is valid, so what i want it to do is:

  1. Verify that the json is valid (being invalid was actually the cause of Intermittent issue reading jsons #40)
  2. Allow what you describe in Add config for hf token or ask user #8 so that you can just modify the config on the CLI without needing to edit a file manually.
    Some progress on this in Add hugie config modify sub-command (resolves #41) #47

@nsorros
Copy link
Contributor

nsorros commented Nov 18, 2022

This is exciting, keep going 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants