-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hugie config modify
sub-command (resolves #41)
#47
Conversation
60d6759
to
2ba21eb
Compare
hugie config modify
sub-command
2ba21eb
to
94e09f3
Compare
hugie config modify
sub-commandhugie config modify
sub-command (resolves #41)
Dont forget to tick the checklist |
@nsorros maybe you forgot to approve this? |
│ list List all the deployed endpoints │ | ||
│ logs Get logs about an endpoint │ | ||
│ test Test an endpoint │ | ||
│ update Update an endpoint │ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this contain config
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's a separate sub command, so it should be in docs/config
def test_inference_endpoint_config_serialization(data_path): | ||
config = InferenceEndpointConfig.from_json(data_path) | ||
config = dict(config) | ||
assert isinstance(config, dict) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe better to test that some data are still there instead of lost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in 667d83a
i had envisioned this slightly differently and closer to
this would kick an interactive session where you can set some of the variables you define
the end goal being that if a user has these variables setup or if they have them as env variables (maybe for the future) then they can simply do maybe a middle ground is to have |
Modify an existing endpoint config file | ||
""" | ||
|
||
config = InferenceEndpointConfig.from_json(path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it work with a path that does not exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it should fail. I will add tests and error handling for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error handling already covered by load_json()
. In order to create the file (if it doesn't exist), we would need to have all the other arguments set, otherwise the file would not be properly specified. I would leave this for the current PR and let's discuss about the next one in relation to #54.
Noe that I was also considering adding a hugie config create
to create a skeleton config file. Perhaps these two will be related.
I was also thinking that |
I don't think a default profile will be very useful for a production setting. We want to be explicitly setting those things and recording them in Git, not relying on a hidden state that exists on someone's laptop. This implements the second point you mention where you can specify an existing config file and make small changes to it on the command line making it easier to deploy and update deployments in CI/CD. The overwrite option allows you to save the new config out so that it can be stored in Git. We are already doing something like this in a Github action for one repo, so whether or not we add additional profile based functionality, I think we should merge |
See my comment below on why I think that we need to rely on config files. We can add an interactive mode to |
Setting an interactive mode might be a nice user experience, add an issue if you agree and we can implement in a later PR |
Agree, I'll add an issue 👍 |
Also bumping to |
Description
hugie config modify command
(resolves Add funcionality for config editing #41)Checklist