Skip to content

Add NER task #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 69 commits into from
Apr 5, 2025
Merged

Add NER task #86

merged 69 commits into from
Apr 5, 2025

Conversation

adgianv
Copy link
Contributor

@adgianv adgianv commented Feb 19, 2025

Description

Add Named Entity Recognition task

Related Issues

Resolves #10.

Changes Made

  • Add Named entity recognition task
  • Made changes to the GliNER bridge to support NER
  • Includes DSPy, GliNER, Instructor, Langchain, OLLama and Outlines bridges

Checklist

  • Tests have been extended to cover changes in functionality
  • Existing and new tests succeed
  • Documentation updated (if applicable)

Screenshots/Examples (if applicable)

@adgianv adgianv linked an issue Feb 19, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
sieves/tasks/predictive/ner/bridges.py 93.96% 14 Missing ⚠️
sieves/tasks/predictive/ner/core.py 94.02% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   92.65%   92.70%   +0.04%     
==========================================
  Files          37       39       +2     
  Lines        2342     2644     +302     
==========================================
+ Hits         2170     2451     +281     
- Misses        172      193      +21     
Files with missing lines Coverage Δ
sieves/engines/glix_.py 91.07% <100.00%> (+0.50%) ⬆️
sieves/tasks/predictive/core.py 100.00% <ø> (ø)
...es/tasks/predictive/information_extraction/core.py 91.83% <ø> (ø)
sieves/tasks/predictive/ner/core.py 94.02% <94.02%> (ø)
sieves/tasks/predictive/ner/bridges.py 93.96% <93.96%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rmitsch
Copy link
Collaborator

rmitsch commented Feb 20, 2025

Regarding the PR template: take a look at how other PRs are structured, yours should follow the same template. GitHub should have given you the same template when you opened the PR?

Also: make sure to mark a PR as draft if it's not ready to be reviewed yet.

@rmitsch rmitsch self-requested a review February 20, 2025 09:11
@rmitsch rmitsch marked this pull request as draft February 20, 2025 09:11
@adgianv adgianv changed the title NER task add NER task Mar 6, 2025
@adgianv adgianv changed the title add NER task Add NER task Mar 6, 2025
Copy link
Collaborator

@rmitsch rmitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test for to_dataset() is missing, otherwise good to go.

@rmitsch rmitsch merged commit 99bec40 into main Apr 5, 2025
3 checks passed
@rmitsch rmitsch deleted the 10-ner branch April 5, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: NER
2 participants