Adds @grant to model for userscripts #317
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisTheTechie
commented
May 24, 2025
TravisTheTechie
commented
- Implements GM.getValue / GM.setValue and that's it so far.
- Needs some work, but I think from some basic testing seems to be working alright.
- Access is scoped to each script.
TravisTheTechie
commented
May 24, 2025
TravisTheTechie
commented
May 24, 2025
TravisTheTechie
commented
May 24, 2025
TravisTheTechie
commented
May 24, 2025
TravisTheTechie
commented
May 24, 2025
TravisTheTechie
force-pushed
the
userscript-grants
branch
from
f51219f to
8298e76
Compare
* Implements GM.getValue / GM.setValue and that's it so far. * Needs some work, but I think from some basic testing seems to be working alright. * Access is scoped to each script.
TravisTheTechie
force-pushed
the
userscript-grants
branch
from
8298e76 to
b00318a
Compare
TravisTheTechie
commented
May 25, 2025
Kwack-Kwack
requested changes
May 26, 2025
|
|
||
| return manifestMap.keys | ||
| .where((String key) => key.startsWith('assets/userscripts/apis/')) | ||
| .where((String key) => key.endsWith('.js')) |
There was a problem hiding this comment.
Possibly a stupid question - why not just .where((String key) => key.startsWith("...") && key.endsWith("..."))?
There was a problem hiding this comment.
Eh, just my habit of breaking things up like this. I like to think about it this way, though I guess technically it is less efficient (depending on the implementation) because you need to iterate twice. Happy to change it.
* Includes a test script now for the API surface; checked it passes in other script hosts * Figured out how to avoid leaking Future/async all the way the stack
TravisTheTechie
commented
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.