Skip to content

Add proper Api framework #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 18, 2020
Merged

Add proper Api framework #5

merged 7 commits into from
Feb 18, 2020

Conversation

lilioid
Copy link
Contributor

@lilioid lilioid commented Feb 11, 2020 •
edited
Loading

This adds django-rest-framework with two plugins as a basic implementation of using an API framework. It closes #3 although still work in progress.

This PR depends on #2

@lilioid lilioid force-pushed the feature/proper_api_framework branch from c7516eb to 548ef7d Compare February 11, 2020 18:19
@lilioid lilioid force-pushed the feature/proper_api_framework branch from 0c6a829 to b440f2f Compare February 11, 2020 19:07
@lilioid
seperate mappings url definitions
b440f2f 
one ulr definition is defining routes under /<version>/api while the other defines
routes under /.
This is needed because /vector/... must be standards-compatible but is
still a part of the mapping app an should therefore be defined in it.
@lilioid
add get_server view to the api definition
f376743
@lilioid lilioid marked this pull request as ready for review February 11, 2020 19:08
@lilioid lilioid requested a review from Akasch February 11, 2020 19:09
Akasch
Akasch requested changes Feb 15, 2020
View reviewed changes
Copy link
Member

@Akasch Akasch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good.

Before the can make the whole app accessible from the internet we have to implement permissions, as for example the reply from the vector/v1/512/all/... endpoint can include secret api keys

@lilioid
Copy link
Contributor Author

lilioid commented Feb 15, 2020

Before the can make the whole app accessible from the internet we have to implement permissions, as for example the reply from the vector/v1/512/all/... endpoint can include secret api keys

True, that's why I've set it up so that only authenticated users are able to interact with the api

Akasch
Akasch approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@Akasch Akasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it should be good

@lilioid lilioid merged commit 8a863bf into master Feb 18, 2020
@lilioid lilioid deleted the feature/proper_api_framework branch February 18, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Akasch Akasch Akasch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Introduce a proper API framework

2 participants

@lilioid @Akasch