Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/smooth height estimation(autoware) #304

Merged

Conversation

KYabuuchi
Copy link

I modified the smoothing_node to only enqueue subscribed positions when the vehicle is in motion.
This change ensures that the altitude estimation continues accurately even when the vehicle stops.

In the past, the smoothing_node pushed the data in queue every time and extract data with velocity when calculating the moving average. As a result, when the vehicle stoped, values couldn't be extracted from the queue, causing the altitude to become 0.

The following figure shows the estimated height being zero when the vehicle stops.
image

Note

  • moving_ratio_threshold is not used.

@rsasaki0109 rsasaki0109 merged commit 63b531c into MapIV:autoware-main Aug 21, 2023
1 check passed
@rsasaki0109
Copy link
Member

Thank you. The changes look fine, so I'll merge them.

@rsasaki0109
Copy link
Member

rsasaki0109 commented Aug 21, 2023

@Aoki-Takanose
Just to confirm, I understand that the moving_judgment_threshold is a threshold used because there are issues with the Doppler velocity at low speeds. However, the Doppler velocity is not used here. Do you know why we are filtering with the moving_judgment_threshold here?

@Aoki-Takanose
Copy link
Contributor

This is because Eagleye requires that GNSS fusion, not just GNSS Doppler, be above a certain speed.
This is Eagleye's concept, and the same process is applied to other estimation parts as well.

If there are any problems with this part of the estimation, they can be solved by modifying the parameter values.

@KYabuuchi KYabuuchi deleted the fix/smooth_height_estimation branch August 21, 2023 05:14
@rsasaki0109 rsasaki0109 changed the title Fix/smooth height estimation Fix/smooth height estimation(autoware) Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants