[pull] devel from nasa:devel #10
Open
+47,042
−22,618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Co-authored-by: kayleyyoung253 <[email protected]>
* Code updates for FPP v2.1.0a11 * Fix link in data products docs * Remove uses of new To keep the leak checker happy * Revise string test * Replace F' with F Prime in data products docs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -170,6 +170,11 @@ | |||
| void setBuffer(const Buffer& buffer //!< The packet buffer | |||
| ); | |||
|
|
|||
| //! Invalidate the packet buffer | |||
| void invalidateBuffer() { | |||
| this->m_buffer = Fw::Buffer(); | |||
Check warning
Code scanning / CodeQL
Unchecked return value Warning
| // Get the priority | ||
| const FwDpPriorityType priority = container.getPriority(); | ||
| this->dpWrittenOut_out(0, portFileName, priority, fileSize); | ||
| this->dpWrittenOut_out(0, fileName, priority, fileSize); |
Check warning
Code scanning / CodeQL
Unchecked function argument Warning
| // Get the priority | ||
| const FwDpPriorityType priority = container.getPriority(); | ||
| this->dpWrittenOut_out(0, portFileName, priority, fileSize); | ||
| this->dpWrittenOut_out(0, fileName, priority, fileSize); |
Check warning
Code scanning / CodeQL
Unchecked function argument Warning
| @@ -71,8 +74,8 @@ | |||
| // ---------------------------------------------------------------------- | |||
|
|
|||
| //! Set the buffer and initialize it to the empty string | |||
| void setBuffer(char* bufferPtr, //!< The buffer pointer | |||
| FwSizeType bufferSize //!< The buffer size | |||
| void setBuffer(char* bufferPtr, //!< The buffer pointer | |||
Check notice
Code scanning / CodeQL
Use of basic integral type Note
| void setBuffer(char* bufferPtr, //!< The buffer pointer | ||
| FwSizeType bufferSize //!< The buffer size | ||
| void setBuffer(char* bufferPtr, //!< The buffer pointer | ||
| StringBase::SizeType bufferSize //!< The buffer size |
Check notice
Code scanning / CodeQL
Use of basic integral type Note
* Added Spi Interface * Added the include * Changed to Drv * Changed general ports to interfaces --------- Co-authored-by: M Starch <[email protected]>
* modified: Drv/TcpClient/TcpClientComponentImpl.cpp * Changed header and implementation for buffer size * Changed size_t to FwSizeType * Missed member variable * Convert types and added a check * Adding cast to assert arg type --------- Co-authored-by: M Starch <[email protected]>
* Added Chennel Interface for Telemtry * Added interfaces to tests * Added interfaces to tests * Fixed Events typo * modified: cmake/test/src/test_unittests.py * Removed spaces * modified: cmake/test/src/test_unittests.py * Reverting LinuxSpiDriver.fpp * Fixing formatting * Missing comma for formatting * Removing trailing spaces --------- Co-authored-by: M Starch <[email protected]>
* Add flag to prepend autocoders to the buildstep * Add some extre comments * Syntax fixes * cmake min version should not have changed * Syntax/algo bug fix
* Update upcoming events * Edits * More edits * spelling: Add google forms URLs to patterns.txt * spelling: add Prime Prime to patterns * Update with link to SMC-IT conference * spelling: Add URLs to patterns --------- Co-authored-by: Thomas Boyer-Chammard <[email protected]>
* Change TCP backlog to 1 * Fix Comment
* Diataxis Regrouping Documentation * fixed typo from three categories to four in documentation * Fixed h4 tag error in TOC and links in Reference README and including Design general.md * Fixed some more links in documentation * Fixed links in documentation * Fix md links * wip * Update Reference * Change title * Make reference a table * Reword getting started * Reword FPP user guide --------- Co-authored-by: Thomas Boyer-Chammard <[email protected]>
* Update fpp version Revise framework code to match * Update fpp version * Update fpp version * Update fpp version
* 2604: SDD in Progress * 2604: Fixed bug in version * 2604: Updates to user defined versions * FP-2604: Updates to Version module and UTs * FP-2604 : Updates based on changes made by Thomas to version.hpp * FP-2604: Updates to Version based on conversations with Tim and Michael * FP-2604: Updates to UTs and respective code changes * FP-2604: Updates based on review comments * FP-2604: Minor updates based on pull request auto comments * FP-2604: Updates to Ref to integrate versions config and include channel packets * FP-2604 : Update function call in UTs for config to match standards * FP-2604: Remove commented out lines so the python formatter passes in the PR * FP-2604: Fixing python formatting issues * FP-2604: Updates to code based on peer review comments * FP-2604: Format *.cpp files, create new Ports dir in Svc * FP-2604: Update spell check errors * FP-2604: Check spell error fixes * FP-2604: Update spell check errors * FP-2604: Validated argument for version_types * FP-2604: Don't think this will make a difference with the CI errors seen in the pull request, but giving it a try * FP-2604: Updates to Version based on updates to Fw::StringBase * FP-2604: Fixing the memory allocation error for autocoded versions files * FP-2604: Fixed target name in version.cmake so ref/top/topology make rule isnt violated * FP-2604: python file formatting error fix * FP-2604: version python script formatting * FP-2604: Trial/error format fixes on python script * FP-2604: Reformatted python script * FP-2604: Updates to fix CI/linux errors * FP-2604: Add UT version for version.cpp * FP-2604: Formatting and styling updates * Delete Svc/Version/test/ut/VersionTesterHelpers.cpp Deleting unneeded test helper file * Deleting dead code in test * Removing blanks in SDD * Removing parameter ports (unused) * FP-2604: Updates to versions based on peer review comments and code scrubbing * FP-2604: Formatting fixes --------- Co-authored-by: M Starch <[email protected]>
* Add Hub Pattern Documentation * Add more description to Hub Pattern * Fix Hub Documentation and Images * Fix Hub Diagram Text and typos * Add Reference Placeholder * Change Port In-Out Description * Fix Spelling * Fix Grammar + Remove Topology.cpp fix * Fix Spelling * Emphasize Example + Reword * Link Hub-Pattern-Example * Fix Spelling * Fix Typo
* Revise file name strings for assertion events * Fix FPP tests * Remove debug print statements * Add comments to config files * Revise FpConfig Also fix bug in CmdSplitterTester * Shorten file name length from 256 to 200 For consitency with AMPCS compatibility code AMPCS arguments have max size 255
* Delete RPI/Top/Topology.cpp * Delete Components.hpp --------- Co-authored-by: Thomas Boyer-Chammard <[email protected]>
* Add pre-processor pattern to docs * Update spelling * Address comments
* Initial work on subtopology documentation * Begin work on MySubtopology.cpp * Draft 1 * Fix technical errors * Remove intentionally-empty.cpp * Working in Thomas' comments; spelling and toc * Spelling * Add note about phases in subtopologies * Link replacement change + info about fprime-util new subtopology * Spelling * Update docs to use phases and mention tool * Address Thomas' comments * Update for comments and addressing autocoder more --------- Co-authored-by: M Starch <[email protected]>
* Update fpp version * Update FPP version to v2.1.0
* Integrating SBOM generation into CMake * Fixing missing 'syft' tool bug, adding documentation * sp
--------- Co-authored-by: ashleynilo <[email protected]>
* Adhering to new mutex api * casting assert arg as expected * Using correct mutex call * Formatting * Fixing interface for wait/pend * Fixing conditionvariable to adhere to new interface * Updated Os::Stub's implementation of ConditionVariable per new interface * Formatting and updating Test's ConditionVariable implementation to the new API * bugfix to ut * Fixes per PR review.
* Removing printf from Ref compontents * Removing printf from Drv * Removing printf from Utils * Adding Fw::StringUtils::format string format helper * Using StringUtils::format in SPI driver * Adding newline to file
* UDP does not bind on send only port. Fixes: #3127 * Refining autoconnection behavior. Fixes: #3144 * Simplifying read loop * I should probably at least build before pushing... * sp * Adding UTs to catch UDP send only * Adding auto-connect disabled UTs * Disabling UDP configure, reconnect -> private, and SDD fixes * Renaming reconnect to reopen * Fixing deployment examples * Add links to SDD * sp
* Stop ignoring real buffers shrunk to 0 size Without this fix, trying to return allocated buffers to a BufferManager with sizes updated to 0 can result in a memory leak. * Rename ZeroSizeBuffer to NullEmptyBuffer
Co-authored-by: Cindy T Huynh <[email protected]>
* Adding additional SCALAR types testing * sp
* forgot to add the dollar sign branch around the BUILD_TESTING variable * removing dead code * Fixing build issues --------- Co-authored-by: M Starch <[email protected]>
* Update requirements.txt * Update fpp version * Revise fpp version * Update fpp version * Update fpp version * Update fpp version
* Starting on FDD for DpCatalog * More DpCatalog SDD edits * More refined DpCatalog requirements * Starting prototype code * Working on DpCatalog build command * More DpCatalog work * More DpCatalog work * More work on reading DP headers * More work... * Continued work * Spelling fixes * More spelling fixes * First run of init unit test * One DP works * Refactor unit test helpers * Working on multiple DPs * More work on multiple DPs * Fixed filesRead bug * More merge fixes * Adding DPs to SignalGen * Adding DP components * Added DP directory to DpWriter * First working version of Data Products! * Added missing FileDownlink connection * Added early proto warning to SDD. * Switched to Fw::FileNameString * Fixed unit test compile * Add missing override keyword * Fix unit test override * Fixed format specifiers * Reformat code * Revise DpWriter uts * Revise dp writer * Revise dp writer * Removed extra ; * Fix markdown broken links * Updated SDD to force CI to run again * Adding async DP request example * Working on async example * Still working on async DP * Remove test printf * Another merge with F Prime devel * Working on binary tree implementation * Work in progress. Doesn't work yet * Still working * debug launch config * fixed pre-launch run step * Some progress on algo * 2 and 3 nodes work * Refactored some code * Tree traverse seems to work! * One transmitted test * Fixed NULL to nullptr * Fixed spelling * Fixed memory alignment * Starting on state file * Fixed spelling - AGAIN * Added reading of the state file * Added function to get state for DP from state file * Added state file data pruning function * Code to update the state file * Debugging DpCat * More work on DPs * Working on state file * Added to spelling expect.txt * fix double 'the' * Testing with DpManager/SignalGen * Some compile fixes * Adding more test cases * Fixed downlink bug * Fix SignalGen unit test * Updated SDD and some CI error fixes * Fix SDD typo * Working on docs * Docs/comments updates * Fix typo * Added random priority test * More random tests * Added stdc to spelling expect * Working on requested fixes * Added DP port tests to SignalGen unit test * Updates to address review issues * Fix assert argument * Fixed some more ut CI errors * Attempting to fix spelling * Removed incorrect comment --------- Co-authored-by: Robert L. Bocchino Jr. <[email protected]> Co-authored-by: M Starch <[email protected]>
* Making string formatting into a fprime implementation choice * Removing printf from Fw and cleaning-up toString methods * Fixes to get UTs to compile * Reverting test change to assert * Removing error console and restoring assert functionality * Create empty library to avoid 3.16 limitations on interface libs * Turning off unused check on intentionally unused variable * sp * Fixing recursive calls and other CI problems * Fixing compile issues
* Exclude Ref SDD from search results * Update source-tree.md
* Updated comment to indicate functions are not ISR safe since they use a mutex under the hood * added another needed comment * Adding warning on priorityqueue usage within an ISR
* Doc restructure with design-patterns and build-system sections * Restore advanced.md and uts.md * Link in UTs * Fix link * Remove card layout from user manual landing page * Add back the cards
* Synchronous cancel guide, and Fw.Signal implementation Fixing name in CMakeList for Fw.Signal Draft of other port patterns More port patterns with reoganized structure Adding completion status port Proof-read ports paterns doc Fixing expert review elements w/ common port patterns Updating links to point to devel examples * Fixing path from old to new * Fix relative links * Update mkdocs.yml and ordering * Fixing [!NOTE] --------- Co-authored-by: Thomas Boyer-Chammard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )