feature: choose custom install location

[AlvinSchiller]

Added the possibility for the user to select a custom location for the game installation instead of only the drive root.

Considering the comment in MarcellVokk/aio-launcher#3 this is available via a "advenced settings" toggleswitch in the installation popup. The original selection is still default for the straight forward case.

Update:

• added toggle switch to change to folder selection settings
• set "program files (x86)" as defaultpath for folder selection
• folders containing ":\Windows" or "\OneDrive" are excluded
• valid drives have to be of type "fixed" (no removable or network drives) -> also effects the original selection
• if no drive is available an error message is shown

[MarcellVokk]

Hi! Made a few comments on the code that need to be worked on before I add this to the main branch.

Also, the UI doesn't look quite right to me, that toggle is placed a bit akwardly, maybe put it inline with the "Location" title, or keep it where it is but put a background on it, or have the toggle text start where the Location title starts horizontaly.
And when "advanced mode" is turned on, there is nothing to indicate that you are supposed to click on the box below to select a folder, maybe put a little folder icon on the right side of the box, and also reduce the vertical padding on that box because with 2 lines it looks a bit akward with that much padding.

[MarcellVokk]

Is this necesary? Use Microsoft.Win32.OpenFolderDialog instead, it's built in and as a bonus it's the new style folder browser, not the old style crappy one.

[MarcellVokk]

Please don't use this naming convention: "_nameOfSomething".
Instead, use: "NameOfSomething" for global values, and "nameOfSomething" for local values.

[AlvinSchiller]

Hi! Made a few comments on the code that need to be worked on before I add this to the main branch.

Also, the UI doesn't look quite right to me, that toggle is placed a bit akwardly, maybe put it inline with the "Location" title, or keep it where it is but put a background on it, or have the toggle text start where the Location title starts horizontaly. And when "advanced mode" is turned on, there is nothing to indicate that you are supposed to click on the box below to select a folder, maybe put a little folder icon on the right side of the box, and also reduce the vertical padding on that box because with 2 lines it looks a bit akward with that much padding.

The idea of the indented "advanced" text was to make the hierarchy clear. If its in line with the title is does not look like sub elements and could be confusing.
I've made changes that all sub elements are intended equally to make a cleaner look.

What do you think? Whould this be ok?

[AlvinSchiller]

Updated the advanced ui:

• Split Text and Button.
• Use Icon on the Button
• set Button height the same as a selectable element

[inmate37]

@MarcellVokk could you please review/merge this ? Extremely necessary feature

[MarcellVokk]

Are you kidding me? That UI looks like shit...

[AlvinSchiller]

@MarcellVokk

Are you kidding me? That UI looks like shit...

Do you mean the folder selection or also the change of the indentation?

Regarding the folder selection i reverted this to the single button design and added the folder icon.

[AlvinSchiller]

Regarding your earlier statement

... and also reduce the vertical padding on that box because with 2 lines it looks a bit akward with that much padding.

For now i used the default padding of the "HiglightButtonStyle" to keep a consistent look.
Also, in my eyes, it looks odd if the vertical padding is reduced. But your call which way to go.
Here an example if the vertical padding is halfed (from 10 to 5)

[inmate37]

@AlvinSchiller @MarcellVokk hey guys, can this one get a little attention ?

[lfechne]

That UI looks okay for a home made app. If UI is your only concern and not security or unexpected behavior of the PR code, then just accept the PR.

Are you kidding me? That UI looks like shit...

Are you kidding us? That is not respectable language towards a fellow developer! You should be ashamed.
If you want to bring together a community here, then be a respectable and grateful person for any helpers.

[inmate37]

@MarcellVokk The UI can be changed later if necessary, as for the code it is okay, lets merge this asap, required feature

[inmate37]

@MarcellVokk If you are busy and cannot review this please consider adding new reviewers for this one

[AlvinSchiller]

As a workaround to change an already existing installation to a custom path (e.g. "D:\BFME2" -> "D:\Games\BFME\BFME2"):
(I did this myself before i created this pr. This is nothing official and at own risk)

• close the launcher
• open "regedit" as an administrator
• search for the current installation path of the game
• change all entries of the game to the new custom path
• move the game folder from the old to the new path
• open the launcher
• validate that the games is still recognized as installed (if not check the paths again)

[inmate37]

Since @MarcellVokk doesn't give 2 F's about our concern, use the following guide to make requested feature possible:

1.
Create the folder Games in drive D:

PS: You can set whatever name, and install the game in whatever drive, I will use drive D: and folder name Games as an example

2.
Move the folders from:

D:\BFME2
D:\BFME Workshop
D:\RotWK

To:

D:\Games\BFME2
D:\Games\BFME Workshop
D:\Games\RotWK

3.
Open: Win+R, then type: regedit

Go to:
HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Electronic Arts\Electronic Arts\The Battle for Middle-earth II

HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Electronic Arts\Electronic Arts\The Lord of the Rings, The Rise of the Witch-king

Change the value in InstallPath to: D:\Games\...

4.
Go to:
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\App Paths\lotrbfme2.exe
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\App Paths\lotrbfme2ep1.exe

Change the value in Default and Path to: D:\Games\...

5.
Run AllInOneLauncher.exe and check that the game is set to: Play not Install

[Jaredl-Dev]

@MarcellVokk Hi, I created a successor PR for this feature here: #23.

Update: A staff member informed me that the code in this repository is outdated and no longer synchronized with the current launcher. They also recommended submitting feature requests through the Discord server instead.

I have already submitted a feature request for this particular feature.