decoration-over-number-issue-fixed #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jerakin
added a commit
to Jerakin/NumberPicker
that referenced
this pull request
Oct 16, 2023
Jerakin
added a commit
to Jerakin/NumberPicker
that referenced
this pull request
Oct 16, 2023
|
Any news on weither or not this will be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request resolves issue #146 by addressing the problem where the decoration was covering the number in the
NumberPickerwidget. The issue occurred because the decoration was placed as the last child in the stack, causing it to cover the other child and appear over the number text.Changes Made:
To resolve this issue, I made the following changes:
Testing:
I have tested these changes by creating and running a Flutter app and confirming that the decoration no longer covers the number.
Screenshots:
Related Issue:
This pull request is related to #146, I created the issue post a few weeks ago when I first used the numberpicker widget in a project and noticed the decoration problem. I had some time today so I decided to go through the source code and noticed that the issue could be fixed by simply rearranging the order of the widgets in the stack and moving the decoration to be the first child i.e the one that appears at the bottom.
Note for Reviewers:
I apologize if I have missed any steps, this is my first public contribution bug fix. Please review these changes and provide feedback or approval as needed. Thank you!