-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Auto Settings #486
Expand Auto Settings #486
Conversation
…ll_rcon_methods' into feat/autosettings_all_rcon_methods
Here's one issue I ran into: {
"result": null,
"command": "/api/get_players_history",
"arguments": null,
"failed": true,
"error": "TypeError(\"'<=' not supported between instances of 'str' and 'int'\")",
"forwards_results": null,
"version": "v9.9.0-127-gb05feb5"
} The error originates from a simple assertion that checks if the values fall within a certain range. hll_rcon_tool/rcon/player_history.py Lines 129 to 147 in 3b66c4e
The RconAPI method itself does specify they're hll_rcon_tool/rcon/api_commands.py Lines 292 to 297 in 3b66c4e
|
…yle names in postgres
This is a big one so it'll be hard to review.
I didn't explicitly name all of the arguments for the
set_
user config endpoints, I cheated and just passed**kwargs
straight through, so it won't auto expose the parameters, but it would have been dramatically more work to do so. If we're happy with all of these changes it wouldn't be hard to go back and explicitly define them later.Rcon
calledRconAPI
and moves almost all of the endpoints that were separately defined into it so that they are available to use with Auto SettingsRcon
(nowRconAPI
) endpoints to account for some edge casesdo_blacklist_player
instead ofblacklist_player
) for instanceget_api_documentation
endpoint to explicitly show which endpoints are usable with Auto Settingsuser config
settings, i.e. instead of passing the entireAutoModSeedingUserConfig
you can pass a single (or multiple) keys likeenabled
and it will merge them with the previous valuesRcon
endpointsremove_flag
to allow removing a flag if a specific player has it (by the string value of the flag) instead of only supporting passing in the primary key of the flag recorsdPOST
andGET
requirements that were being done by endpoint name, for instance theget_recent_logs
endpoint has a lot of parameters and is traditionally passed via JSONI believe (but I have not explicitly tested 100% of this manually) that I preserved the previous behaviors and argument names and I've been running this on our RCON for awhile now (two weeks maybe?) and have fixed all of the problems I've been able to find with it.
Old versus new API documentation: https://www.diffchecker.com/Km3MOLEV/