Merge markdown diagnostic changes to neovim master

.clang-tidy

@@ -14,6 +14,7 @@ Checks: >
   section for it,
   -bugprone-assignment-in-if-condition,
   -bugprone-implicit-widening-of-multiplication-result,
+  -bugprone-multi-level-implicit-pointer-conversion,
   -bugprone-not-null-terminated-result,
   -bugprone-suspicious-memory-comparison,
   -bugprone-switch-missing-default-case,
@@ -32,14 +33,17 @@ Checks: >
   -hicpp-signed-bitwise,
   -misc-unused-parameters,
   -modernize-macro-to-enum,
+  -readability-avoid-nested-conditional-operator,
   -readability-else-after-return,
+  -readability-enum-initial-value,
   -readability-function-size,
   -readability-isolate-declaration,
 
   Warnings that are rarely useful,
   -altera-*, Checks related to OpenCL programming for FPGAs. Not relevant,
   -android-*,
   -bugprone-easily-swappable-parameters,
+  -bugprone-inc-dec-in-conditions,
   -bugprone-swapped-arguments,
   -clang-analyzer-*, Already covered by the cmake target "clang-analyzer",
   -cppcoreguidelines-avoid-non-const-global-variables,
@@ -53,6 +57,7 @@ Checks: >
   -readability-function-cognitive-complexity,
   -readability-identifier-length,
   -readability-magic-numbers,
+  -readability-math-missing-parentheses,
   -readability-redundant-declaration, Conflicts with our header generation scripts,
   -readability-suspicious-call-argument,
 
@@ -62,9 +67,13 @@ Checks: >
   -cert-dcl51-cpp,
   -cert-exp42-c,
   -cert-flp37-c,
+  -cert-int09-c,
   -cert-msc24-c,
   -cert-msc33-c,
   -cppcoreguidelines-avoid-magic-numbers,
+  -cppcoreguidelines-macro-to-enum,
+  -google-readability-braces-around-statements,
   -google-readability-function-size,
+  -hicpp-braces-around-statements,
   -hicpp-function-size,
   -llvm-else-after-return,

.editorconfig

@@ -13,6 +13,6 @@ max_line_length = 100
 [*.py]
 indent_size = 4
 
-[{Makefile,**/Makefile,runtime/doc/*.txt}]
+[{Makefile,**/Makefile,*.mk,runtime/doc/*.txt}]
 indent_style = tab
 indent_size = 8

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -1,6 +1,6 @@
 name: Bug Report
-description: Report a problem in Neovim
-labels: [bug]
+description: Report a problem in Nvim
+type: 'bug'
 body:
 
   - type: markdown
@@ -43,7 +43,7 @@ body:
 
   - type: input
     attributes:
-      label: "Neovim version (nvim -v)"
+      label: "Nvim version (nvim -v)"
       placeholder: "0.6.0 commit db1b0ee3b30f"
     validations:
       required: true

.github/ISSUE_TEMPLATE/config.yml

@@ -1,5 +1,5 @@
 blank_issues_enabled: false
 contact_links:
   - name: Question
-    url: https://vi.stackexchange.com/
-    about: Ask questions about configuration and usage of Neovim
+    url: https://github.com/neovim/neovim/discussions
+    about: Ask about configuration and usage of Nvim

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -1,6 +1,6 @@
 name: Feature request
-description: Request an enhancement for Neovim
-labels: [enhancement]
+description: Request an enhancement for Nvim
+type: 'enhancement'
 body:
 
   - type: markdown

.github/ISSUE_TEMPLATE/lsp_bug_report.yml

@@ -1,6 +1,8 @@
 name: Language server (LSP) client bug
-description: Report an issue with Neovim LSP
-labels: [bug, lsp]
+description: Report an issue with Nvim LSP
+title: "LSP: "
+type: bug
+labels: [lsp]
 body:
 
   - type: markdown
@@ -59,7 +61,7 @@ body:
 
   - type: input
     attributes:
-      label: "Neovim version (nvim -v)"
+      label: "Nvim version (nvim -v)"
       placeholder: "0.6.0 commit db1b0ee3b30f"
     validations:
       required: true

.github/scripts/close_unresponsive.js

@@ -26,7 +26,7 @@ module.exports = async ({ github, context }) => {
         repo: repo,
         issue_number: number,
       },
-      (response) => response.data.filter(labeledEvent)
+      (response) => response.data.filter(labeledEvent),
     );
 
     const latest_response_label = events[events.length - 1];

.github/scripts/install_deps.sh

@@ -16,9 +16,9 @@ if [[ $os == Linux ]]; then
 
   if [[ $CC == clang ]]; then
     DEFAULT_CLANG_VERSION=$(echo |  clang -dM -E - | grep __clang_major | awk '{print $3}')
-    CLANG_VERSION=18
+    CLANG_VERSION=19
     if ((DEFAULT_CLANG_VERSION >= CLANG_VERSION)); then
-      echo "Default clang version is $DEFAULT_CLANG_VERSION, which equal or larger than wanted version $CLANG_VERSION. Aborting!"
+      echo "Default clang version is $DEFAULT_CLANG_VERSION, which is equal or larger than wanted version $CLANG_VERSION. Aborting!"
       exit 1
     fi
 
@@ -30,10 +30,10 @@ if [[ $os == Linux ]]; then
   fi
 
   if [[ -n $TEST ]]; then
-    sudo apt-get install -y locales-all cpanminus attr libattr1-dev gdb fswatch
+    sudo apt-get install -y locales-all cpanminus attr libattr1-dev gdb inotify-tools
 
     # Use default CC to avoid compilation problems when installing Python modules
-    CC=cc python3 -m pip -q install --user --upgrade pynvim
+    CC=cc python3 -m pip -q install --user --upgrade --break-system-packages pynvim
   fi
 elif [[ $os == Darwin ]]; then
   brew update --quiet

.github/scripts/labeler_configuration.yml

@@ -1,71 +1,91 @@
-lsp:
+build:
   - changed-files:
-    - any-glob-to-any-file: [ runtime/lua/vim/lsp.lua, runtime/lua/vim/lsp/* ]
+    - any-glob-to-any-file: [ CMakeLists.txt, "**/CMakeLists.txt", "**/Makefile", "**/*.cmake", cmake.deps/**/* ]
 
-tui:
+checkhealth:
   - changed-files:
-    - any-glob-to-any-file: [ src/nvim/tui/tui.* ]
+    - any-glob-to-any-file: [ "**/health.lua" ]
 
-treesitter:
+ci:
   - changed-files:
-    - any-glob-to-any-file: [ src/nvim/lua/treesitter.*, runtime/lua/vim/treesitter.lua, runtime/lua/vim/treesitter/*, runtime/queries/**/* ]
+    - any-glob-to-any-file: [ .github/actions/**, .github/workflows/**, .github/scripts/** ]
+
+clipboard:
+  - changed-files:
+    - any-glob-to-any-file: [ runtime/autoload/provider/clipboard.vim ]
+
+column:
+  - changed-files:
+    - any-glob-to-any-file: [ src/nvim/sign* ]
+
+comment:
+  - changed-files:
+    - any-glob-to-any-file: [ runtime/lua/vim/_comment.lua ]
+
+defaults:
+  - changed-files:
+    - any-glob-to-any-file: [ runtime/lua/vim/_defaults.lua ]
 
 diagnostic:
   - changed-files:
     - any-glob-to-any-file: [ runtime/lua/vim/diagnostic.lua ]
 
-dependencies:
+diff:
   - changed-files:
-    - any-glob-to-any-file: [ cmake.deps/**/* ]
+    - any-glob-to-any-file: [ src/nvim/diff.* ]
 
-spell:
+documentation:
   - changed-files:
-    - any-glob-to-any-file: [ src/nvim/spell* ]
+    - any-glob-to-all-files: [ runtime/doc/*, "**/*.md" ]
 
-terminal:
+editorconfig:
   - changed-files:
-    - any-glob-to-any-file: [ src/nvim/terminal.* ]
+    - any-glob-to-any-file: [ .editorconfig, runtime/lua/editorconfig.lua, runtime/plugin/editorconfig.lua ]
 
-column:
+filetype:
   - changed-files:
-    - any-glob-to-any-file: [ src/nvim/sign* ]
+    - any-glob-to-any-file: [ runtime/lua/vim/filetype.lua, runtime/lua/vim/filetype/detect.lua ]
+
+filesystem:
+  - changed-files:
+    - any-glob-to-any-file: [ runtime/lua/vim/fs.lua ]
 
 folds:
   - changed-files:
     - any-glob-to-any-file: [ src/nvim/fold* ]
 
+lsp:
+  - changed-files:
+    - any-glob-to-any-file: [ runtime/lua/vim/lsp.lua, runtime/lua/vim/lsp/* ]
+
 mouse:
   - changed-files:
     - any-glob-to-any-file: [ src/nvim/mouse* ]
 
-documentation:
+netrw:
   - changed-files:
-    - any-glob-to-all-files: [ runtime/doc/*, "**/*.md" ]
+    - any-glob-to-any-file: [ runtime/autoload/netrw.vim, runtime/plugin/netrwPlugin.vim ]
 
-clipboard:
+snippet:
   - changed-files:
-    - any-glob-to-any-file: [ runtime/autoload/provider/clipboard.vim ]
+    - any-glob-to-any-file: [ runtime/lua/vim/snippet.lua ]
 
-diff:
+spell:
   - changed-files:
-    - any-glob-to-any-file: [ src/nvim/diff.* ]
+    - any-glob-to-any-file: [ src/nvim/spell* ]
 
-build:
+terminal:
   - changed-files:
-    - any-glob-to-any-file: [ CMakeLists.txt, "**/CMakeLists.txt", "**/Makefile", "**/*.cmake" ]
+    - any-glob-to-any-file: [ src/nvim/terminal.* ]
 
 test:
   - changed-files:
     - any-glob-to-all-files: [test/**/*]
 
-ci:
-  - changed-files:
-    - any-glob-to-any-file: [ .github/actions/**, .github/workflows/**, .github/scripts/** ]
-
-filetype:
+treesitter:
   - changed-files:
-    - any-glob-to-any-file: [ runtime/lua/vim/filetype.lua, runtime/lua/vim/filetype/detect.lua ]
+    - any-glob-to-any-file: [ src/nvim/lua/treesitter.*, runtime/lua/vim/treesitter.lua, runtime/lua/vim/treesitter/*, runtime/queries/**/* ]
 
-platform:nix:
+tui:
   - changed-files:
-    - any-glob-to-any-file: [ contrib/flake.lock, contrib/flake.nix ]
+    - any-glob-to-any-file: [ src/nvim/tui/tui.* ]

.github/scripts/reviewers_add.js

@@ -23,12 +23,12 @@ module.exports = async ({ github, context }) => {
     reviewers.add("lewis6991");
   }
 
-  if (labels.includes("defaults")) {
-    reviewers.add("gpanders");
+  if (labels.includes("comment")) {
+    reviewers.add("echasnovski");
   }
 
-  if (labels.includes("dependencies")) {
-    reviewers.add("jamessan");
+  if (labels.includes("defaults")) {
+    reviewers.add("gpanders");
   }
 
   if (labels.includes("diagnostic")) {
@@ -39,28 +39,28 @@ module.exports = async ({ github, context }) => {
     reviewers.add("lewis6991");
   }
 
-  if (labels.includes("distribution")) {
-    reviewers.add("jamessan");
-  }
-
-  if (labels.includes("documentation")) {
-    reviewers.add("clason");
+  if (labels.includes("editorconfig")) {
+    reviewers.add("gpanders");
   }
 
-  if (labels.includes("extmarks")) {
+  if (labels.includes("marks")) {
     reviewers.add("bfredl");
   }
 
   if (labels.includes("filetype")) {
     reviewers.add("clason");
-    reviewers.add("gpanders");
-    reviewers.add("smjonas");
+  }
+
+  if (labels.includes("inccommand")) {
+    reviewers.add("famiu");
   }
 
   if (labels.includes("lsp")) {
-    reviewers.add("folke");
     reviewers.add("MariaSolOs");
-    reviewers.add("mfussenegger");
+  }
+
+  if (labels.includes("netrw")) {
+    reviewers.add("justinmk");
   }
 
   if (labels.includes("options")) {
@@ -76,18 +76,19 @@ module.exports = async ({ github, context }) => {
     reviewers.add("justinmk");
   }
 
-  if (labels.includes("statusline")) {
-    reviewers.add("famiu");
+  if (labels.includes("snippet")) {
+    reviewers.add("MariaSolOs");
   }
 
-  if (labels.includes("test")) {
-    reviewers.add("justinmk");
+  if (labels.includes("statusline")) {
+    reviewers.add("famiu");
   }
 
   if (labels.includes("treesitter")) {
     reviewers.add("bfredl");
     reviewers.add("clason");
     reviewers.add("lewis6991");
+    reviewers.add("wookayin");
   }
 
   if (labels.includes("tui")) {
@@ -99,7 +100,6 @@ module.exports = async ({ github, context }) => {
   }
 
   if (labels.includes("vim-patch")) {
-    reviewers.add("seandewar");
     reviewers.add("zeertzjq");
   }
 

.github/workflows/backport.yml

@@ -12,11 +12,35 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - name: Create backport PRs
-        uses: korthout/backport-action@v2
+
+      - uses: actions/create-github-app-token@v1
+        id: app-token
         with:
-          # https://github.com/korthout/backport-action/pull/399
-          experimental: >
-            {
-              "detect_merge_method": true
-            }
+          app-id: ${{ vars.BACKPORT_APP }}
+          private-key: ${{ secrets.BACKPORT_KEY }}
+
+      - name: Create backport PR
+        id: backport
+        uses: korthout/backport-action@v3
+        with:
+          pull_title: "${pull_title}"
+          label_pattern: "^ci:backport ([^ ]+)$"
+          github_token: ${{ steps.app-token.outputs.token }}
+
+      - name: Create failed backport label
+        if: ${{ steps.backport.outputs.was_successful == 'false' }}
+        uses: actions/github-script@v7
+        with:
+          script: |
+            github.rest.issues.addLabels({
+              issue_number: context.issue.number,
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              labels: ['needs:backport']
+            })
+
+      - name: Enable automerge
+        if: ${{ steps.backport.outputs.was_successful == 'true' }}
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: gh pr merge --rebase --auto ${{ steps.backport.outputs.created_pull_numbers }}