Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Standardized API error semantics to stabilize backend contract behavior and remove accidental
500responses.Introduced explicit domain exceptions for clearer intent and predictable status mapping:
ResourceNotFoundException→404 Not FoundAccessDeniedException→403 ForbiddenDomainConflictException→409 ConflictInvalidInputException→400 Bad RequestUpdated global exception handling to consistently map validation/auth/domain failures (
MethodArgumentNotValidException,ConstraintViolationException, JWT/auth errors) to expected HTTP responses.Replaced service-layer throws of framework/generic exceptions (
ResponseStatusException,IllegalArgumentException,NoSuchElementException) in hardened paths with domain-level exceptions.Removed accidental 500 propagation hotspots caused by unsafe Optional access and
require(...)failures in touched flows.500statuses.Type of change
Validation
Commands run:
./gradlew test --testsDocs impact
Security impact
This change improves contract hardening for authentication/authorization/validation responses by preventing ambiguous or accidental 500 leaks and enforcing deterministic HTTP semantics (401/403/404/400/409) across touched backend flows.