fix(pdf-zoom): scrolling issue with toolbar

MarkUsProject · Nov 22, 2024 · cd39093 · cd39093
1 parent 257aace
commit cd39093
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 12 deletions.
diff --git a/app/assets/javascripts/Components/Result/pdf_viewer.jsx b/app/assets/javascripts/Components/Result/pdf_viewer.jsx
@@ -144,7 +144,7 @@ export class PDFViewer extends React.PureComponent {
     const zoomValuesToDisplayName = this.getZoomValuesToDisplayName();
 
     return (
-      <div>
+      <React.Fragment>
         <div className="toolbar">
           <div className="toolbar-actions">
             {I18n.t("results.current_rotation", {rotation: this.state.rotationInDegrees})}
@@ -169,7 +169,7 @@ export class PDFViewer extends React.PureComponent {
           <div
             id="pdfContainer"
             className="pdfContainer"
-            style={{cursor, userSelect, overflow: "auto"}}
+            style={{cursor, userSelect}}
             ref={this.pdfContainer}
           >
             <div id="viewer" className="pdfViewer" />
@@ -181,7 +181,7 @@ export class PDFViewer extends React.PureComponent {
             />
           </div>
         </div>
-      </div>
+      </React.Fragment>
     );
   }
 }
diff --git a/app/assets/stylesheets/common/pdfjs_custom.scss b/app/assets/stylesheets/common/pdfjs_custom.scss
@@ -1,5 +1,7 @@
 .pdfContainerParent {
   position: relative;
+  overflow: auto;
+  height: 100%;
 }
 
 .pdfContainer {

diff --git a/app/assets/stylesheets/grader.scss b/app/assets/stylesheets/grader.scss
@@ -26,15 +26,7 @@
 
 /* Panes content (for controlling the heights) */
 
-#codeviewer {
-  display: flex;
-  flex-basis: 600px;
-  flex-direction: column;
-  flex-grow: 1;
-  width: 100%;
-  overflow: hidden;
-}
-
+#codeviewer,
 #testviewer,
 #mark_viewer,
 #summary_viewer,