Feature/escrow balance invariant#144
Merged
Cybermaxi7 merged 9 commits intoMarketXpress:mainfrom Mar 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #123
Description
This PR guarantees the mathematical invariant that the smart contract's token balance must inherently be perfectly tracked and always strictly greater than or equal to
TotalFundedAmountminusTotalReleasedAmount.Changes Included
create_escrow): Detached the superficial increment toTotalFundedAmountout of the constructor bounds so it doesn't inflate stats before tokens arrive.fund_escrow): Safely movedTotalFundedAmountincrements squarely into thetoken_client.transferbounds.release_escrow,release_item,resolve_dispute): Implemented persistent tracking forTotalReleasedAmountglobally across all endpoints that distribute tokens out of the smart contract's canonical local map.test_contract_balance_invariant): Extended the integration environment to repeatedly evaluate the bounds equation across multi-party disputes and dynamic resolution paths to mathematically affirm 0 token bleeds natively.Review Guide
Reviewers should specifically review
contracts/marketx/src/lib.rsendpoints:fund_escrowrelease_escrowrelease_itemresolve_dispute