feat: implement contract upgradeability API (Closes #125)#145
Merged
Cybermaxi7 merged 1 commit intoMarketXpress:mainfrom Mar 28, 2026
Merged
feat: implement contract upgradeability API (Closes #125)#145Cybermaxi7 merged 1 commit intoMarketXpress:mainfrom
Cybermaxi7 merged 1 commit intoMarketXpress:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #125
Description
This PR integrates the standard Soroban mutable upgrade execution pipelines into the
MarketXContract. It unlocks the ability for the Admin to hot-swap bug fixes and patch enhancements directly onto the deployed contract map without migrating the underlying ledger.Changes Included
lib.rs):upgradeendpoint that safely executes the nativeenv.deployer().update_current_contract_wasm(new_wasm_hash)vector.Self::assert_admin(&env)?boundary block, explicitly trapping any execution requests from end-users, fee collectors, or unauthorized arbiters.test.rs):test_upgrade_auth_failure: Validates authentication blocks by spinning up a mockupgradeenvironment and asserting that external random non-admin invokers fail cleanly with anis_err()catch.test_upgrade_state_persistence: Simulates a fully funded Escrow node and executes a live testdummy hashupgrade across the test ledger, subsequently re-querying the exactescrow_idnode mapping to mathematically assertescrow.amount == 1000is preserved linearly across the environment transaction line unharmed.Review Guide
Reviewers should specifically verify the
upgradelogic inside the Admin Block incontracts/marketx/src/lib.rs.