ci: fix workflow breakages across 4 workflows - #2
Closed
Masked18 wants to merge 1 commit into
Closed
Conversation
benchmarks.yml: remove duplicate Enforce benchmark thresholds step and merge threshold summary into single step; fix baseline artifact path from non-existent new.txt to handlers_new.txt and subscriptions_new.txt; upgrade security job from checkout@v3 and setup-go@v4 to v4 and v5 fuzz.yml: remove 3 dangling job refs fuzz-swap-exact-in, fuzz-swap-exact-out, fuzz-swap-raw-body from fuzz-summary needs array that have no corresponding jobs and cause the workflow to always fail test-jwt-hardening.yml: replace non-existent Go 1.24 and 1.25 matrix versions with 1.22 and 1.23; upgrade setup-go@v4 to v5 in both jobs; replace bc-based coverage comparison with portable awk reconciliation-ci.yml: upgrade setup-go@v4 to v5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full audit of all 16 CI workflows. Four had bugs causing jobs to always fail or behave incorrectly.
Changes
benchmarks.yml
Enforce benchmark thresholdsstep — the step ID appeared twice, the second one also wrote the GITHUB_STEP_SUMMARY; merged both into one stepUpdate baselineartifact path — uploadednew.txtwhich is never produced; corrected to the actual output fileshandlers_new.txt+subscriptions_new.txtsecurityjob:actions/checkout@v3->@v4,setup-go@v4->@v5fuzz.yml
fuzz-summaryneeds array:fuzz-swap-exact-in,fuzz-swap-exact-out,fuzz-swap-raw-body— none of these jobs exist in the workflow, causing the summary job to always error on startuptest-jwt-hardening.yml
1.24/1.25(not released) with1.22/1.23setup-go@v4->@v5in bothtestandlintjobsbc-based coverage threshold (not available on all runners) with portableawkreconciliation-ci.yml
setup-go@v4->@v5