Implementing conversions from int to System.Windows.Media.Color for MaterialColorUtilities #3949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt32 and System.Windows.Media.Color representations
…heme from a primary color
|
ℹ️ The follwoing changes where ammended:
|
Keboo
approved these changes
Oct 24, 2025
| </PropertyGroup> | ||
|
|
||
| <!-- WPF may not be available when we want to target non-windows platforms in future --> | ||
| <PropertyGroup Condition="'$(TargetFramework)' == 'net462' OR '$(TargetFramework)' == 'net8.0-windows'"> |
There was a problem hiding this comment.
I think for now it is safe to assume that this is just targeting WPF. to actually pull it out, would mean also conditioning the <UseWpf> above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inttoSystem.Windows.Media.ColorNotes:
System.Windows.Media.Coloris not available when targeting Non-WPF (WinForms, MAUI, MacOS, Linux, etc.) plattforms. E.g. the following is not supported:Microsoft.Maui.Graphics.Color)System.Drawing.Color)Splat.SplatColor)