Skip to content

Conversation

SangJunBak
Copy link
Contributor

Add self-managed password authentication tests

Add tests to test self managed password auth for past patch releases upgrading to the latest self managed patch release

Motivation

Followup for incident 697

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@SangJunBak SangJunBak requested a review from a team as a code owner September 29, 2025 21:44
@SangJunBak SangJunBak requested a review from def- September 29, 2025 21:45
@SangJunBak SangJunBak force-pushed the jun/add-rbac-test-2 branch 4 times, most recently from aecfc10 to 6c4fda7 Compare October 3, 2025 21:17
@SangJunBak SangJunBak requested a review from a team as a code owner October 6, 2025 21:46
@SangJunBak SangJunBak requested a review from ggevay October 6, 2025 21:46
@SangJunBak SangJunBak force-pushed the jun/add-rbac-test-2 branch 3 times, most recently from b370ee1 to d7dba80 Compare October 7, 2025 03:51
@SangJunBak SangJunBak requested a review from def- October 7, 2025 14:08
@SangJunBak
Copy link
Contributor Author

@def- SQLLogictests failed bc. enabled_password_auth creates a code path that handles role creation differently. Not sure if I should adjust these tests or disable password auth for them. I think role.slt and role_create.slt can just be updated since all it tests is that the LOGIN, SUPERUSER syntax is invalid for cloud. However pg_catalog_user.slt explictly tests against a code path for email domains.

@SangJunBak SangJunBak force-pushed the jun/add-rbac-test-2 branch 2 times, most recently from b29583d to 01c53f0 Compare October 10, 2025 20:24
Add tests to test self managed password auth for past patch releases upgrading to the latest self managed patch release
- Opens up port 6880 for password auth in testdrive
- Defaults listener config to custom one for tests
- Allows port to be referenced in testdrive fragments
- Enables password auth feature flag for all materialized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants