Update columnar, timely, differential #33938
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
force-pushed
the
update_c_td_dd
branch
from
76e19c9 to
af8b4ed
Compare
antiguru
commented
Oct 28, 2025
Comment on lines
+1198
to
+1201
| if let Some(frontier) = &ts_rewrite { | ||
| h.write_usize(frontier.len()); | ||
| frontier.iter().for_each(|t| t.encode().hash(&mut h)); | ||
| } |
There was a problem hiding this comment.
@bkirwi Do you think this change is correct? We don't require Timestamp to be Hash, so instead of requiring it, I'm pivoting to hasing the codec.
There was a problem hiding this comment.
Yeah, this is fine! Codec64 guarantees that it's equally unique, and since this is just a debug assert helper we don't have to worry too much about the (probably very small number of) extra cycles.
Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
force-pushed
the
update_c_td_dd
branch
from
26058c6 to
2f8d051
Compare
def-
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Columnar, Timely and Differential.
TODO:
The async operator builder in its current form will emit single-record containers.✔️ Also removed unsafe code.